For each theme, there are files redefining the different website SCSS
variables, in order for the color palettes, fonts, buttons,... to have
the styles defined by them. These redefinitions are also used by the
"Theme Options", to show the current values in the different widgets.
In order for the primary buttons to be "outlined", the "Enark" theme set
the `btn-primary-outline` variable to `'true'`. However, this value
should be a boolean instead of a string. Indeed, since the option does
not recognize the string value, the "Buttons Primary Style" widget
therefore shows a "/" instead of "Outline", which is not correct.
This commit fixes this by setting a boolean value.
opw-3957157
closesodoo/design-themes#810
X-original-commit: 14ff983da2
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
The following commit [1] added a test to verify that there are no
duplicate classes in the elements of predefined page templates.
This test worked fine until it failed when we attempted to merge a
commit in which a template is rendered with empty spaces in the class
attribute of an element. The test considered the empty spaces as classes
and therefore assumed that two identical classes existed.
This commit excludes empty spaces when retrieving classes in this test.
[1]: https://github.com/odoo/design-themes/commit/758e2ab819df37c56103b1e82f1e6358b3dba00c
task-3662985
closesodoo/design-themes#788
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Some themes were making the s_picture image responsive on their own. It
is now done generically, so the theme extensions must be removed to be
able to merge.
task-3266862
closesodoo/design-themes#784
Related: odoo/odoo#157808
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Commit [1] introduced a new test that uninstalls theme_buzzy. This leads
to the whole module being uninstalled because this module has all themes
as dependencies.
To fix this, we just run the test as the last test, ensuring the module
is still installed for other tests.
Ideally, tests would be independent from one another, but for now, the
order matters.
[1]: https://github.com/odoo/design-themes/commit/4cdd1db20c021ebd369b46c739591def9732eec5closesodoo/design-themes#779
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
In PR [1], the duplicated navbars ids `o_main_nav` and `top_menu` are
replaced by classes, to avoid having the same ids multiple times in the
DOM. Note that for stability, the ids are kept for the desktop view
navbar.
This commit adapts the tests so they now consider the classes and not
the ids.
[1]: https://github.com/odoo/odoo/pull/146492
task-3609531
closesodoo/design-themes#756
Related: odoo/odoo#146492
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Commit [1] introduced new images for the theme, alongside their related
ir.attachment definition. Later, a refactoring of the theme was made at
commit [2]. During that refactoring, multiple mistakes were made. Three
image files were removed: s_image_text.jpg, s_text_image.jpg and
s_banner.jpg. Out of these 3, only one related ir.attachment was
adapted to not use the removed image anymore: s_banner. Thus this left
two dead ir.attachment pointing to images that do not exist anymore.
Note that the banner image was actually restored later at [3]. Until
there... just dead code, although it could potentially be used and crash
by custo (this is why this targets the same version as [2]). Indeed, [2]
also patched the use of those two removed images in their related
snippet by changing the related image sources directly (using a special
route of the web_editor which generates SVG).
However, in [4], we started using one of those two images (via its xmlid
/ key) in another snippet: the new image snippet. This thus break the
kea theme when using that new snippet because the ir.attachment that is
used for that image still referenced an image that was removed by [2].
[1]: https://github.com/odoo/design-themes-old/commit/66bf0fc439f8549b00cbdf2eaa2b9517b6ac9876
[2]: https://github.com/odoo/design-themes/commit/004e38398a98ba61e587bf12b8bfc5e396baa434
[3]: https://github.com/odoo/design-themes/commit/5b8e14b83dba05e23d2a20418484b56b5f3b05cc
[4]: https://github.com/odoo/odoo/commit/507b80a12574ce19bcb925d88868fb377b1c4b06
opw-3689096
closesodoo/design-themes#775
X-original-commit: 5778e692f9
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
To make sure the required primary templates have been generated from
the theme's manifest when inherited views are imported/updated, this
commit triggers their generation from a first imported XML file.
This has been added to all themes for consistency, even the ones that
do not require it currently.
Related to https://github.com/odoo/odoo/pull/148443
task-3670496
Part-of: odoo/design-themes#755
When shapes were extracted to configurator snippets in [1], some
configurator-specific snippets were created that do not appear on pages
of the specific theme.
Because in [2] the call to `_generate_primary_snippet_templates` is done
on a full list of themes instead of only the installed ones, the problem
was not noticed: if any theme defines a block, it's website-side
configurator-specific template is generated.
This is not the case during an upgrade: the templates are generated only
for the installed themes. Because of this some "useless" configurator
templates trigger an error when importing their XML definition because
their parent template does not exist.
This commit fixes this by adding those templates in a pseudo page `_` in
the `configurator_snippets` entry of each theme's manifest.
In master, the templates will be removed instead.
[1]: https://github.com/odoo/design-themes/commit/d206c119720d557c11320ebb3d7339890b8f9efa
[2]: https://github.com/odoo/odoo/commit/928eeca714a161f6bc03343e4dc8af9b050b9841#diff-f49a1e9eda23df9f1d48121ba376a5fabafe70ea18b29d4eab23d737e5d4eeb6R446closesodoo/design-themes#751
Related: odoo/odoo#144222
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Steps to reproduce
==================
Run the `test_02_homepage_tour_every_theme` tour.
Cause of the issue
==================
There is an homepage tour for every theme. Since the owl conversion of
web_tour, none of the custom theme tour were run and for every website,
the default homepage tour was used instead.
Some updates to those themes caused the tours to fail, but since they
weren't run, no one noticed.
The issue has been fixed in community:
https://github.com/odoo/odoo/pull/142350
Solution
========
Since 1aa6700c98,
some h1 tags were replaced by h2.
Since 68c68740bf,
The banner has been replaced by a text cover.
opw-3595512
Part-of: odoo/design-themes#745
This commit adds a test that makes sure templates can be rendered on
all themes and that they neither contain duplicate classes nor
contradicting ones.
Covered templates:
- snippet blocks
- configurator snippet customizations
- new page template snippet customizations
task-3562147
closesodoo/design-themes#731
Related: odoo/odoo#139572
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Given that the duplicate and conflicting classes resolved by the
previous commit did still exist at the time new page templates were
introduced in [1], they could not be avoided for new page templates
snippets.
This commit removes those from the new page templates snippets now that
they have been removed from the base snippets.
[1]: https://github.com/odoo/design-themes/commit/80cbee66f6bb4d897dd7e577f1109c75f6f6ad74
task-3562147
Part-of: odoo/design-themes#731
This commit rephrases one of the quotes block's sentences to use the
word "academic" instead of "diplomatic".
closesodoo/design-themes#742
X-original-commit: 5534cda1bc
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Since [1] when background shapes were extracted to configurator-specific
templates, some xpath were broken.
By separating the definition of the shape from the definition of the
base snippet theme customization, changes between `container`,
`container-fluid` and `o_container_small` are already applied before
taking the shape definition into account.
This commit fixes the templates which have this issue.
[1]: https://github.com/odoo/design-themes/commit/d206c119720d557c11320ebb3d7339890b8f9efa
task-3555325
closesodoo/design-themes#732
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
In [1] all shapes were moved from the base snippet to the specific
configurator snippet. This was a bit overkill.
This commit reverts this partially so that only shapes that connect
with each other are specific to the configurator, but "intra-block"
shapes are restored onto the base snippet.
The "New page from template" snippets are adapted accordingly in order
to produce the same output as before this commit.
Restored shapes are: (label (image))
- Origins: 12 (18)
- Blob: 11 (11)
- Airy: 03 (03_001), 04 (04_001), 07 (07), 10 (10), 11 (11), 14 (14)
- Zigs: 01 (01_001), 02 (02_001)
- Wavy: 04 (10), 15 (11)
- Blocks: 02 (01_001)
- Rainy: 03 (06), 05 (10), 09 (08_001), 10 (09_001)
- Floats: all
[1]: https://github.com/odoo/design-themes/commit/d206c119720d557c11320ebb3d7339890b8f9efa
task-3555325
closesodoo/design-themes#726
Related: odoo/odoo#138748
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Themes translation in Odoo 16 have been lost, they were not exported on
Transifex anymore (bug).
We just added back the repository on it, and our internal translators
are working on those translations.
They found some typos and bad wording which are fixed here.
Technically, note that we need the themes fully translated for the
chatGPT integration coming in website configurator.
Indeed, if a theme is not (almost fully) translated, it won't be using
chatGPT for text replacement.
This is because if we ask chatGPT to do text replacement and translation
at the same time, it just provides bad results.
See https://github.com/odoo/odoo/pull/137703closesodoo/design-themes#725
X-original-commit: 7cdb6d2ab7
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Odoo Translation Bot