*: theme_notes, theme_real_estate, theme_yes, theme_zap, theme_vehicle
Along with xPath adaptations, this commit also replaces a pixelated
image in the 'theme_yes'.
task-3665303
part of task-3619705
closesodoo/design-themes#839
Related: odoo/odoo#173870
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
This commit removes a useless template from the enark theme.
Prior to this commit, the old `numbers` snippet was only displaying
KPI without any title + lead, meaning that we had more room to display
numbers.
This space allowed us to display a KPI with its label side-by-side, which
is not more possible with the new snippet.
To improve consistency, we remove that template and go for the default one.
closesodoo/design-themes#822
Related: odoo/odoo#163583
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
This commit reviews the occurrences of the numbers snippets across
the website themes, especially broken selector.
The goal of this commit is to fix potential broken xpath as wel as
fine-tune the design if needed.
task-3924624
Part-of: odoo/design-themes#822
Related: odoo/odoo#163583
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
*: theme_artists, theme_avantgarde, theme_beauty, theme_bewise,
theme_bistro, theme_bookstore, theme_buzzy, theme_clean, theme_kiddo,
theme_loftspace, theme_notes, theme_odoo_experts, theme_orchid,
theme_paptic
This commit adapts the s_product_catalog customizations since this
snippet has been redesigned in PR [1].
task-3665307
Part of task-3619705
[1]:https://github.com/odoo/odoo/pull/173507closesodoo/design-themes#833
Related: odoo/odoo#173507
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
*: (artists, buzzy, graphene)
This commit removes the customization of icon colors, as we are not
using them in the Odoo 18 redesign.
It also adapts the background of numbers to increase contrasts.
It also removes a title customization in the graphene theme as it was
not changing anything from the default snippet.
task-3672430
closesodoo/design-themes#840
Related: odoo/odoo#174166
Signed-off-by: Colin Louis (loco) <loco@odoo.com>
*: (anelusia, beauty, bewise, graphene, notes, yes)
This commit adapts the design of `s_company_team` for multiple themes,
based on the new Odoo 18 snippet redesign.
task-3657640
closesodoo/design-themes#844
Related: odoo/odoo#172719
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
*: (artists, bookstore, cobalt, enark, graphene, monglia, real_estate,
vehicle, yes, zap)
This commit adapts the design of `s_image_wall` for multiple themes,
based on the new Odoo 18 snippet redesign.
task-3654301
closesodoo/design-themes#843
Related: odoo/odoo#163839
Signed-off-by: Robin Lejeune (role) <role@odoo.com>
*: theme_artists, theme_beauty, theme_bewise, theme_buzzy, theme_clean,
theme_cobalt, theme_kea, theme_loftspace, theme_notes,
theme_odoo_experts, theme_paptic, theme_treehouse, theme_zap
This commit adapts the s_color_blocks_2 customizations since this
snippet has been redesigned in PR [1].
task-3665302
Part of task-3619705
[1]: https://github.com/odoo/odoo/pull/173461closesodoo/design-themes#834
Related: odoo/odoo#173461
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
This commit aims to review all the occurrences of the `s_banner`
snippet across the themes in order to fix broken selectors, the `s_hr` in
our case, as it does not exist anymore in the snippet.
task-3665300
closesodoo/design-themes#827
Related: odoo/odoo#172725
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
This commit aims to review all the occurrences of the `s_text_cover`
snippet across the themes in order to fix broken selectors.
task-3665300
Part-of: odoo/design-themes#827
Related: odoo/odoo#172725
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
This commit aims to review all the occurrences of the `s_cover`
snippet across the themes in order to fix broken selectors.
task-3665300
Part-of: odoo/design-themes#827
Related: odoo/odoo#172725
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
This commit aims to review all the occurrences of the `s_image_text`
snippet across the themes in order to fix broken selectors.
task-3665301
closesodoo/design-themes#830
Related: odoo/odoo#173311
Signed-off-by: Robin Lejeune (role) <role@odoo.com>
This commit aims to review all the occurrences of the `s_text_image`
snippet across the themes in order to fix broken selectors.
task-3665301
Part-of: odoo/design-themes#830
Related: odoo/odoo#173311
Signed-off-by: Robin Lejeune (role) <role@odoo.com>
The goal of this commit is to fix xpath after the `s_picture` snippet
redesign, and eventually tweak some classes.
task-4047748
closesodoo/design-themes#824
Related: odoo/odoo#172740
Signed-off-by: Arthur Detroux (ard) <ard@odoo.com>
The goal of this commit is to remove some obsolete templates of the
`s_features` snippet across design themes, due to changes in the
redesign that invalidate the need of modifying these specific elements.
task-3657631
closesodoo/design-themes#826
Related: odoo/odoo#163577
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
The goal of this commit is to review the occurrences of the
default `s_features` snippet across design themes.
task-3657631
Part-of: odoo/design-themes#826
Related: odoo/odoo#163577
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
Following the change in the way of dragging and dropping a snippet onto
the page (by selecting it from a dialog displaying the actual previews
of snippets). The themes tours have been adapted to this change in this
commit.
task-3919405
closesodoo/design-themes#817
Related: odoo/odoo#166967
Related: odoo/enterprise#66150
Signed-off-by: Robin Lejeune (role) <role@odoo.com>
In order to simplify the tours API, it was decided to remove the
extra_trigger key from the steps.
To check that an element is in the DOM, simply create a step with
a trigger.
task~3974087
closesodoo/design-themes#816
Related: odoo/odoo#171309
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
For each theme, there are files redefining the different website SCSS
variables, in order for the color palettes, fonts, buttons,... to have
the styles defined by them. These redefinitions are also used by the
"Theme Options", to show the current values in the different widgets.
In order for the primary buttons to be "outlined", the "Enark" theme set
the `btn-primary-outline` variable to `'true'`. However, this value
should be a boolean instead of a string. Indeed, since the option does
not recognize the string value, the "Buttons Primary Style" widget
therefore shows a "/" instead of "Outline", which is not correct.
This commit fixes this by setting a boolean value.
opw-3957157
closesodoo/design-themes#814
X-original-commit: 14ff983da2
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Currently, in tour_compiler, to check that an element is actually
present in the DOM in a step, there are 2 possibilities.
- `isCheck: true` => Checks that the element is in the DOM.
The latter can be disabled.
- `run() {}` => Checks that the element is in the DOM (because this
is what is done by default). However, if the element is disabled,
the step will be aborted.
In the codebase, we can see a lot of `run() {} //it's a check` and
`isCheck:true`. However, the behavior is not exactly the same.
What's more, there are 2 ways to do "the same thing".
In order to clarify the turns API, it was decided to no longer put an
action (step.run) by default. (Previously, the default action was
the "click" action).
From then on, it is no longer necessary to stipulate
`step.isCheck: true` nor `run() {}`.
The corollary is that now, you must explicitly write `run: click`, if
you want the click action to be triggered on the target.
This commit sets the stage for making this change.
closesodoo/design-themes#801
Related: odoo/odoo#167743
Related: odoo/enterprise#63711
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
The following commit [1] added a test to verify that there are no
duplicate classes in the elements of predefined page templates.
This test worked fine until it failed when we attempted to merge a
commit in which a template is rendered with empty spaces in the class
attribute of an element. The test considered the empty spaces as classes
and therefore assumed that two identical classes existed.
This commit excludes empty spaces when retrieving classes in this test.
[1]: https://github.com/odoo/design-themes/commit/758e2ab819df37c56103b1e82f1e6358b3dba00c
task-3662985
closesodoo/design-themes#792
X-original-commit: 05cfe05280
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
Some themes were making the s_picture image responsive on their own. It
is now done generically, so the theme extensions must be removed to be
able to merge.
task-3266862
closesodoo/design-themes#787
X-original-commit: 08cb536b02
Related: odoo/odoo#157813
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit removes the overrides of scss variables that are set to the
default value and duplicated overrides.
task-2463604
closesodoo/design-themes#768
Signed-off-by: Outagant Mehdi (mou) <mou@odoo.com>
In this commit, we change rest of triggers in tours where an iframe is
selected (suite of #156653).
To do this, we use the :iframe HOOT pseudo-selector.
With this changes, we can now remove the getNodesFromSelector
function in odoo/addons/web_tour/static/src/tour_service/tour_utils.js
Note that in this previous function, a ([is-ready]="true") check was
made for iframe elements but was only necessary for few of them (7).
So, a stepUtils.waitIframeIsReady() has been added to check this state.
closesodoo/design-themes#783
Related: odoo/odoo#157217
Related: odoo/enterprise#58474
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
In PR [1], the duplicated navbars ids `o_main_nav` and `top_menu` are
replaced by classes, to avoid having the same ids multiple times in the
DOM. Note that for stability, the ids are kept for the desktop view
navbar.
This commit adapts the tests so they now consider the classes and not
the ids.
[1]: https://github.com/odoo/odoo/pull/146492
task-3609531
closesodoo/design-themes#780
X-original-commit: 103e544835
Related: odoo/odoo#156013
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Commit [1] introduced a new test that uninstalls theme_buzzy. This leads
to the whole module being uninstalled because this module has all themes
as dependencies.
To fix this, we just run the test as the last test, ensuring the module
is still installed for other tests.
Ideally, tests would be independent from one another, but for now, the
order matters.
[1]: https://github.com/odoo/design-themes/commit/4cdd1db20c021ebd369b46c739591def9732eec5closesodoo/design-themes#782
X-original-commit: 45e9374699
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
Commit [1] introduced new images for the theme, alongside their related
ir.attachment definition. Later, a refactoring of the theme was made at
commit [2]. During that refactoring, multiple mistakes were made. Three
image files were removed: s_image_text.jpg, s_text_image.jpg and
s_banner.jpg. Out of these 3, only one related ir.attachment was
adapted to not use the removed image anymore: s_banner. Thus this left
two dead ir.attachment pointing to images that do not exist anymore.
Note that the banner image was actually restored later at [3]. Until
there... just dead code, although it could potentially be used and crash
by custo (this is why this targets the same version as [2]). Indeed, [2]
also patched the use of those two removed images in their related
snippet by changing the related image sources directly (using a special
route of the web_editor which generates SVG).
However, in [4], we started using one of those two images (via its xmlid
/ key) in another snippet: the new image snippet. This thus break the
kea theme when using that new snippet because the ir.attachment that is
used for that image still referenced an image that was removed by [2].
[1]: https://github.com/odoo/design-themes-old/commit/66bf0fc439f8549b00cbdf2eaa2b9517b6ac9876
[2]: https://github.com/odoo/design-themes/commit/004e38398a98ba61e587bf12b8bfc5e396baa434
[3]: https://github.com/odoo/design-themes/commit/5b8e14b83dba05e23d2a20418484b56b5f3b05cc
[4]: https://github.com/odoo/odoo/commit/507b80a12574ce19bcb925d88868fb377b1c4b06
opw-3689096
closesodoo/design-themes#777
X-original-commit: 5778e692f9
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit addresses the issue with the customization of the s_picture
snippet within the theme_vehicle. Previously, this snippet enforced a
column height, which cannot be modified using the editor. Themes should
not impose customizations that users are unable to adjust using the
editor.
See also : odoo/odoo#145413
task-3626753
Part-of: odoo/design-themes#753
To make sure the required primary templates have been generated from
the theme's manifest when inherited views are imported/updated, this
commit triggers their generation from a first imported XML file.
This has been added to all themes for consistency, even the ones that
do not require it currently.
Related to https://github.com/odoo/odoo/pull/148443
task-3670496
X-original-commit: 22abe61eaf
Part-of: odoo/design-themes#761
Steps to reproduce
==================
Run the `test_02_homepage_tour_every_theme` tour.
Cause of the issue
==================
There is an homepage tour for every theme. Since the owl conversion of
web_tour, none of the custom theme tour were run and for every website,
the default homepage tour was used instead.
Some updates to those themes caused the tours to fail, but since they
weren't run, no one noticed.
The issue has been fixed in community:
https://github.com/odoo/odoo/pull/142350
Solution
========
Since 1aa6700c98,
some h1 tags were replaced by h2.
Since 68c68740bf,
The banner has been replaced by a text cover.
opw-3595512
X-original-commit: 2e263a4f6b
Part-of: odoo/design-themes#746
Xavier Luyckx (xlu)