[IMP] review numbers snippets occurrences across design themes

This commit reviews the occurrences of the numbers snippets across
the website themes, especially broken selector.

The goal of this commit is to fix potential broken xpath as wel as
fine-tune the design if needed.

task-3924624

Part-of: odoo/design-themes#822
Related: odoo/odoo#163583
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>

theme_anelusia/views/snippets/s_numbers.xml

@@ -4,7 +4,7 @@
 <template id="s_numbers" inherit_id="website.s_numbers">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="o_half_screen_height o_cc4" remove="o_cc2" separator=" "/>
+        <attribute name="class" add="o_half_screen_height o_cc4" remove="o_cc1" separator=" "/>
         <attribute name="data-oe-shape-data">{"shape":"web_editor/Airy/10","flip":[]}</attribute>
     </xpath>
     <!-- Shape -->

theme_artists/views/snippets/s_numbers.xml

@@ -4,7 +4,7 @@
 <template id="s_numbers" inherit_id="website.s_numbers">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="pb120 pt120 o_cc5" remove="pb24 pt24 o_cc2" separator=" "/>
+        <attribute name="class" add="pb120 pt120 o_cc5" remove="pt80 pb80 o_cc1" separator=" "/>
     </xpath>
 </template>
 

theme_beauty/views/snippets/s_numbers.xml

@@ -4,7 +4,7 @@
 <template id="s_numbers" inherit_id="website.s_numbers">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="o_cc3" remove="o_cc2" separator=" "/>
+        <attribute name="class" add="o_cc3" remove="o_cc1" separator=" "/>
         <attribute name="data-oe-shape-data">{"shape":"web_editor/Rainy/10","flip":[]}</attribute>
     </xpath>
     <!-- Shape -->

theme_bewise/views/customizations.xml

@@ -83,7 +83,7 @@
 <!-- ======== NUMBERS ======== -->
 <template id="s_numbers" inherit_id="website.s_numbers" name="Be Wise s_numbers">
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="o_cc3" remove="o_cc2" separator=" "/>
+        <attribute name="class" add="o_cc3" remove="o_cc1" separator=" "/>
         <attribute name="data-oe-shape-data">{"shape":"web_editor/Blobs/11","flip":["x"]}</attribute>
     </xpath>
     <xpath expr="//section/div" position="before">
@@ -98,12 +98,6 @@
     <xpath expr="//div[hasclass('row')]/div[3]/h6" position="replace" mode="inner">
         Libraries
     </xpath>
-    <xpath expr="//div[hasclass('row')]/div[4]/h6" position="replace" mode="inner">
-        Students
-    </xpath>
-    <xpath expr="//div[hasclass('row')]/div[4]/span" position="replace" mode="inner" >
-        16,456
-    </xpath>
 </template>
 
 <!-- ======== QUOTES ======== -->

theme_bistro/views/snippets/s_numbers.xml

@@ -4,7 +4,7 @@
 <template id="s_numbers" inherit_id="website.s_numbers">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="o_cc5 pt80 pb80" remove="o_cc2 pt24 pb24" separator=" "/>
+        <attribute name="class" add="o_cc5" remove="o_cc1" separator=" "/>
     </xpath>
 </template>
 

theme_bookstore/views/snippets/s_numbers.xml

@@ -4,7 +4,7 @@
 <template id="s_numbers" inherit_id="website.s_numbers">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="o_cc1 pt112 pb112" remove="o_cc2 pt24 pb24" separator=" "/>
+        <attribute name="class" add="pt112 pb112" remove="pt80 pb80" separator=" "/>
         <attribute name="data-oe-shape-data">{"shape":"web_editor/Floats/12","flip":[]}</attribute>
     </xpath>
     <!-- Shape -->
@@ -21,9 +21,6 @@
     <xpath expr="//h6" position="replace" mode="inner">
         Amazing pages
     </xpath>
-    <xpath expr="//h6" position="replace" mode="inner">
-        Outstanding images
-    </xpath>
 </template>
 
 </odoo>

theme_buzzy/views/snippets/s_numbers.xml

@@ -4,7 +4,7 @@
 <template id="s_numbers" inherit_id="website.s_numbers">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="o_cc4 pt96 pb96" remove="o_cc2 pt24 pb24" separator=" "/>
+        <attribute name="class" add="o_cc4 pt96 pb96" remove="o_cc1 pt80 pb80" separator=" "/>
         <attribute name="data-oe-shape-data">{"shape":"web_editor/Zigs/02_001","flip":[]}</attribute>
     </xpath>
     <!-- Shape -->

theme_clean/views/snippets/s_numbers.xml

@@ -4,7 +4,7 @@
 <template id="s_numbers" inherit_id="website.s_numbers">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="o_cc4 pt64" remove="o_cc2 pt24" separator=" "/>
+        <attribute name="class" add="o_cc4 pt64" remove="o_cc1 pt80" separator=" "/>
         <attribute name="data-oe-shape-data">{"shape":"web_editor/Airy/10","flip":[]}</attribute>
     </xpath>
     <!-- Shape -->

theme_graphene/views/customizations.xml

@@ -181,7 +181,7 @@
 <!-- ======== NUMBERS ======== -->
 <template id="s_numbers" inherit_id="website.s_numbers" name="Graphene s_numbers">
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="oe_img_bg o_bg_img_center pb56 pt56 s_parallax_no_overflow_hidden parallax s_parallax_is_fixed" remove="pb24 pt24" separator=" "/>
+        <attribute name="class" add="oe_img_bg o_bg_img_center pb56 pt56 s_parallax_no_overflow_hidden parallax s_parallax_is_fixed o_cc3" remove="pb80 pt80 o_cc1" separator=" "/>
     </xpath>
     <xpath expr="//section/div[hasclass('container')]" position="before">
         <span class="s_parallax_bg oe_img_bg" style="background-image: url('/web/image/website.s_parallax_default_image'); background-position: 50% 75%;"/>
@@ -197,9 +197,6 @@
     <xpath expr="(//div[hasclass('row')]/div/span)[3]" position="attributes">
         <attribute name="class" add="text-white" separator=" "/>
     </xpath>
-    <xpath expr="(//div[hasclass('row')]/div/span)[4]" position="attributes">
-        <attribute name="class" add="text-white" separator=" "/>
-    </xpath>
 </template>
 
 <!-- ======== PICTURE ======== -->

theme_graphene/views/new_page_template.xml

@@ -106,6 +106,12 @@
     </xpath>
 </template>
 
+<template id="new_page_template_about_full_s_numbers" inherit_id="website.new_page_template_about_full_s_numbers">
+    <xpath expr="//section" position="attributes">
+        <attribute name="class" remove="o_cc3" separator=" "/>
+    </xpath>
+</template>
+
 <template id="new_page_template_about_personal_s_text_block_h2" inherit_id="website.new_page_template_about_personal_s_text_block_h2">
     <xpath expr="//section" position="attributes">
         <attribute name="class" add="o_cc5" remove="o_cc3" separator=" "/>

theme_kea/views/snippets/s_numbers.xml

@@ -4,7 +4,7 @@
 <template id="s_numbers" inherit_id="website.s_numbers">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="pt0 pb48" remove="pt24 pb24" separator=" "/>
+        <attribute name="class" add="pt0 pb48" remove="pt80 pb80" separator=" "/>
     </xpath>
     <!-- Replace h6 by paragraphs -->
     <xpath expr="//h6" position="replace" mode="inner">
@@ -16,9 +16,6 @@
     <xpath expr="(//h6)[3]" position="replace" mode="inner">
         Number of controllers
     </xpath>
-    <xpath expr="(//h6)[4]" position="replace" mode="inner">
-        New games every week
-    </xpath>
 </template>
 
 </odoo>

theme_loftspace/views/snippets/s_numbers.xml

@@ -4,7 +4,7 @@
 <template id="s_numbers" inherit_id="website.s_numbers">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="pt80 pb192 o_cc5" remove="pt24 pb24 o_cc2" separator=" "/>
+        <attribute name="class" add="pb192 o_cc5" remove="pb80 o_cc1" separator=" "/>
         <attribute name="data-oe-shape-data">{"shape":"web_editor/Airy/03_001","flip":["y"]}</attribute>
     </xpath>
     <!-- Shape -->

theme_notes/views/new_page_template.xml

@@ -134,7 +134,7 @@
 
 <template id="new_page_template_about_full_s_numbers" inherit_id="website.new_page_template_about_full_s_numbers">
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="o_cc o_cc2 pt24 pb24" remove="o_cc3 pt0 pb0" separator=" "/>
+        <attribute name="class" add="o_cc2 pt24 pb24" remove="o_cc3 pt0 pb0" separator=" "/>
     </xpath>
 </template>
 
@@ -161,7 +161,7 @@
 <template id="new_page_template_about_personal_s_numbers" inherit_id="website.new_page_template_about_personal_s_numbers">
     <xpath expr="//section" position="attributes">
         <!-- pt0 is defined by both theme and new page template -->
-        <attribute name="class" add="o_cc pt0" remove="pt0" separator=" "/>
+        <attribute name="class" add="pt0" remove="pt0" separator=" "/>
     </xpath>
 </template>
 

theme_notes/views/snippets/s_numbers.xml

@@ -4,14 +4,14 @@
 <template id="s_numbers" inherit_id="website.s_numbers">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="pt0 pb0" remove="pt24 pb24 o_cc o_cc2" separator=" "/>
+        <attribute name="class" add="pt0 pb0" remove="pt80 pb80" separator=" "/>
     </xpath>
     <!-- Container -->
     <xpath expr="//div[hasclass('container')]" position="attributes">
         <attribute name="class" add="container-fluid" remove="container" separator=" "/>
     </xpath>
     <!-- Column #1 -->
-    <xpath expr="//div[hasclass('col-lg-3')]" position="attributes">
+    <xpath expr="//div[hasclass('col-lg-4')]" position="attributes">
         <attribute name="class" add="pt104 pb104 o_cc o_cc5" remove="pt24 pb24" separator=" "/>
     </xpath>
     <!-- Column #1 - Text -->
@@ -19,7 +19,7 @@
         Editions through the Europe
     </xpath>
     <!-- Column #2 -->
-    <xpath expr="//div[hasclass('col-lg-3')][2]" position="attributes">
+    <xpath expr="//div[hasclass('col-lg-4')][2]" position="attributes">
         <attribute name="class" add="pt104 pb104 o_cc o_cc2" remove="pt24 pb24" separator=" "/>
     </xpath>
     <!-- Column #2 - Text -->
@@ -27,21 +27,13 @@
         Artists from around the world
     </xpath>
     <!-- Column #3 -->
-    <xpath expr="//div[hasclass('col-lg-3')][3]" position="attributes">
+    <xpath expr="//div[hasclass('col-lg-4')][3]" position="attributes">
         <attribute name="class" add="pt104 pb104 o_cc o_cc3" remove="pt24 pb24" separator=" "/>
     </xpath>
     <!-- Column #3 - Text -->
     <xpath expr="(//h6)[3]" position="replace" mode="inner">
         Scenes outdoor &amp; indoor
     </xpath>
-    <!-- Column #4 -->
-    <xpath expr="//div[hasclass('col-lg-3')][4]" position="attributes">
-        <attribute name="class" add="pt104 pb104 o_cc o_cc4" remove="pt24 pb24" separator=" "/>
-    </xpath>
-    <!-- Column #4 - Text -->
-    <xpath expr="(//h6)[4]" position="replace" mode="inner">
-        Loyal partners
-    </xpath>
 </template>
 
 </odoo>

theme_odoo_experts/views/snippets/s_numbers.xml

@@ -4,7 +4,7 @@
 <template id="s_numbers" inherit_id="website.s_numbers">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="pt200 pb200 oe_img_bg o_bg_img_center o_cc4" remove="pt24 pb24 o_cc2" separator=" "/>
+        <attribute name="class" add="pt200 pb200 oe_img_bg o_bg_img_center o_cc4" remove="pt80 pb80 o_cc1" separator=" "/>
         <attribute name="style">background-image:url('/web_editor/shape/theme_odoo_experts/s_numbers.svg?c1=o-color-1');</attribute>
     </xpath>
     <!-- Numbers -->
@@ -17,9 +17,6 @@
     <xpath expr="(//span[hasclass('s_number')])[3]" position="replace" mode="inner">
         <b>8</b>
     </xpath>
-    <xpath expr="(//span[hasclass('s_number')])[4]" position="replace" mode="inner">
-        <b>37</b>
-    </xpath>
 </template>
 
 </odoo>

theme_orchid/views/snippets/s_numbers.xml

@@ -4,7 +4,7 @@
 <template id="s_numbers" inherit_id="website.s_numbers">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="o_cc3" remove="o_cc2" separator=" "/>
+        <attribute name="class" add="o_cc3" remove="o_cc1" separator=" "/>
         <attribute name="data-oe-shape-data">{"shape":"web_editor/Floats/12","flip":[]}</attribute>
     </xpath>
     <!-- Shape -->

theme_paptic/views/customizations.xml

@@ -323,7 +323,7 @@
 <!-- ==== Numbers ===== -->
 <template id="s_numbers" inherit_id="website.s_numbers" name="Paptic s_numbers">
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="pt80 pb80 o_cc4" remove="pt24 pb24 o_cc2" separator=" "/>
+        <attribute name="class" add="o_cc4" remove="o_cc1" separator=" "/>
         <attribute name="data-oe-shape-data">{"shape":"web_editor/Blocks/01_001","flip":[]}</attribute>
     </xpath>
     <!-- Shape -->

theme_real_estate/views/snippets/s_numbers.xml

@@ -4,36 +4,29 @@
 <template id="s_numbers" inherit_id="website.s_numbers">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="o_cc1 pt32 pb56" remove="o_cc2 pt24 pb24" separator=" "/>
+        <attribute name="class" add="pt32 pb56" remove="pt80 pb80" separator=" "/>
     </xpath>
     <!-- Column #01 -->
-    <xpath expr="//div[hasclass('col-lg-3')][1]/h6" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('col-lg-4')][1]/h6" position="replace" mode="inner">
         properties already sold
     </xpath>
-    <xpath expr="//div[hasclass('col-lg-3')][1]/span" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('col-lg-4')][1]/span" position="replace" mode="inner">
         14,000
     </xpath>
     <!-- Column #02 -->
-    <xpath expr="//div[hasclass('col-lg-3')][2]/span" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('col-lg-4')][2]/span" position="replace" mode="inner">
         97%
     </xpath>
-    <xpath expr="//div[hasclass('col-lg-3')][2]/h6" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('col-lg-4')][2]/h6" position="replace" mode="inner">
         happy customers
     </xpath>
     <!-- Column #03 -->
-    <xpath expr="//div[hasclass('col-lg-3')][3]/span" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('col-lg-4')][3]/span" position="replace" mode="inner">
         142
     </xpath>
-    <xpath expr="//div[hasclass('col-lg-3')][3]/h6" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('col-lg-4')][3]/h6" position="replace" mode="inner">
         amazing agents
     </xpath>
-    <!-- Column #04 -->
-    <xpath expr="//div[hasclass('col-lg-3')][4]/span" position="replace" mode="inner">
-        100+
-    </xpath>
-    <xpath expr="//div[hasclass('col-lg-3')][4]/h6" position="replace" mode="inner">
-        offices
-    </xpath>
 </template>
 
 </odoo>

theme_vehicle/views/customizations.xml

@@ -70,7 +70,7 @@
 <template id="s_numbers" inherit_id="website.s_numbers">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="o_cc4 pt48 pb48" remove="o_cc2 pt24 pb24" separator=" "/>
+        <attribute name="class" add="o_cc4 pt48 pb48" remove="o_cc1 pt80 pb80" separator=" "/>
     </xpath>
 </template>
 

theme_zap/views/snippets/s_numbers.xml

@@ -2,10 +2,6 @@
 <odoo>
 
 <template id="s_numbers" inherit_id="website.s_numbers">
-    <!-- Section -->
-    <xpath expr="//section" position="attributes">
-        <attribute name="class" add="pt80 pb80" remove="pt24 pb24" separator=" "/>
-    </xpath>
     <!-- Column #01 -->
     <xpath expr="//*[hasclass('row')]/*[1]" position="attributes">
         <attribute name="class" add="o_cc o_cc1 rounded pt64 pb64" remove="pt24 pb24" separator=" "/>
@@ -30,14 +26,6 @@
     <xpath expr="(//h6)[3]" position="replace" mode="inner">
         <font class="text-o-color-1">Languages</font>
     </xpath>
-    <!-- Column #04 -->
-    <xpath expr="//*[hasclass('row')]/*[4]" position="attributes">
-        <attribute name="class" add="o_cc o_cc1 rounded pt64 pb64" remove="pt24 pb24" separator=" "/>
-        <attribute name="style" add="box-shadow: rgba(0, 0, 0, 0.15) 0px 2px 4px 0px !important;" separator=" "/>
-    </xpath>
-    <xpath expr="(//h6)[4]" position="replace" mode="inner">
-        <font class="text-o-color-1">Projects</font>
-    </xpath>
 </template>
 
 </odoo>