Currently, an error occurs while importing an 'Experts' theme template.
Steps to produce:
- Install the 'website' module.
- Build one website, try to switch its theme to the 'Experts' theme.
ValueError:
External ID not found in the system: website.configurator_s_picture
When switching a website theme to the 'Experts' theme, an error occurs
during importing their XML definition because their parent template does
not exist. To resolve this issue we can remove this template.
Indeed, that configurator snippet override was not needed anymore since
the 'Experts' theme was not using that specific snippet for their
configurator pages anymore. The error went unnoticed because on runbot
all themes are installed, and at least one of them was using that
specific snippet in a configurator page. This will be improved.
See [1] with the same kind of issue.
[1]: https://github.com/odoo/design-themes/commit/aed6d0585be5c646e1c3cade419c706dc154efaf
Sentry-5962594281
closesodoo/design-themes#985
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: loftspace, real_estate
In commit [1], the test for the "Loftspace" and "Real Estate" themes has
been disabled, as their tour was not working.
This commit fixes the tours and reenables the test for these themes. The
issue was coming from the fact that they were trying to drop more
snippets than there really are, which made an acces to the array at an
inexisting index.
[1]: https://github.com/odoo/design-themes/commit/04f90cd883826bb8e4cbf8975aff6c14bf3c64dbclosesodoo/design-themes#976
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit fixes multiples issues in the theme:
- Wording
- Shapes that should appear only in the configurator
- Useless xpaths
- Font bug in Firefox (-> texts have been outlined in the svg)
task-4221731
closesodoo/design-themes#972
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
*: theme_bistro, theme_buzzy, theme_clean, theme_kea, theme_kiddo,
theme_notes, theme_real_estate, theme_vehicle, theme_avantgarde
Prior to this change, some themes were still using default images for
certain snippets.
These images didn't correspond to the subject of the chosen theme.
This commit replaces these images with more relevant ones.
task-4215915
closesodoo/design-themes#958
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit adds a test that highlights mismatches in grid-related
options (classes, grid-area style...).
It also fixes the remaining issues in themes about it.
task-4213996
closesodoo/design-themes#969
Related: odoo/odoo#182029
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Also disable the two theme tours that currently do not pass (for some
reason, they are not even starting at all). To fix later.
Part-of: odoo/design-themes#969
Related: odoo/odoo#182029
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit fixes three minors issues about the `s_call_to_action` snippet.
1) The `background-image` is missing the classes to set it to cover,
leading to a weird positioning of the image ;
2) The `background-image` was not the right one ;
3) The `s_call_to_action` snippet was missing from the theme screenshot.
task-4217986
follow-up of task-4178092
Part-of: odoo/design-themes#969
Related: odoo/odoo#182029
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit fixes an issue about these two themes previews not being
similar to the other ones.
Prior to this commit, some difference were existing between themes
screenshot. With the revamp of the themes, these differences were
fixed. But an other issue was introduced within the screenshots of the
themes I worked on. Other modules were installed, making the header
filled with more `nav-link`. Sometimes the editor button was even visible.
This commit replaces these screenshots with new ones, aligned on the
other themes.
task-4218255
Part-of: odoo/design-themes#969
Related: odoo/odoo#182029
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Revamp the themes, add new images and adapt the existing snippets to fit
the new design.
task-4178014
Part of task-4177975
Part-of: odoo/design-themes#969
Related: odoo/odoo#182029
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit replaces the "dragNDrop" function used in theme tours with
"insertSnippet" because the function name has changed. Now, users no
longer need to drag and drop categories onto the page from the snippet
menu. Instead, they now need to click on them.
task-4072655
closesodoo/design-themes#916
Related: odoo/odoo#180471
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: buzzy, clean, notes
A highlighted text has the following structure:
```
<span class="o_text_highlight o_text_highlight_[highlightId]"
style="--text-highlight-width: ...; --text-highlight-color: ...;">
<span class="o_text_highlight_item">
text content (line 1) ...
<svg.../>
</span>
[<br/>]
<span class="o_text_highlight_item">
text content (line 2) ...
<svg.../>
</span>
...
</span>
```
Which is saved in a minimal format that allows the JS code to rebuild
the SVGs when it's needed:
```
<span class="o_text_highlight o_text_highlight_[highlightId]"
style="--text-highlight-width: ...; --text-highlight-color: ...;">
text content ...
</span>
```
The goal of this commit is to use the simplified format for theme
customizations and adapt the code from the "Snippets Preview" and the
"New Page Templates Preview" to be able to build the highlights using
this format when provided in XML.
task-4215788
closesodoo/design-themes#956
Related: odoo/odoo#181884
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit revamp the design of the `theme_loftspace`.
task-4178079
part of task-4177975
closesodoo/design-themes#910
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
*: bewise, loftspace, monglia, notes, vehicle
In the community PR, the `s_carousel_intro` snippet has been modified in
order to not be in `display: flex` anymore.
This commit adapts this snippet customizations to these changes. More
precisely, it adapts the vertical padding and the grid areas to the text
content, in order to avoid having an overflow.
It also fixes the "Monglia" customization by removing the background
color of the slides, in order to make the added shape visible.
Related to task-4077628
closesodoo/design-themes#915
Related: odoo/odoo#180515
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: anelusia, avantgarde, beauty, bistro, bookstore, enark, kiddo,
loftspace, monglia, nano, notes, odoo_experts, paptic, real_estate,
treehouse, yes, zap
In the community PR, the `s_card_offset` snippet has been modified in
order to not be in `display: flex` anymore. The visual was then kept as
close as possible to how it was before by using the grid padding.
This commit adapts this snippet customizations to these changes. More
precisely, it adapts the vertical padding to the text content, in order
to center it a bit while avoiding having an overflow.
Related to task-4105038
Part-of: odoo/design-themes#915
Related: odoo/odoo#180515
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: vehicle
In the community PR, the `s_image_title` snippet has been modified in
order to not be in `display: flex` anymore, as it could cause issues
with images. The same visual was obtained by setting a `grid-area` in a
way that the text block is at the bottom right.
This commit adapts this snippet customizations to these changes. More
precisely, it adapts the `grid-area` and padding to the text content, in
order to avoid having an overflow while still looking like before.
Related to task-4105319
Part-of: odoo/design-themes#915
Related: odoo/odoo#180515
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
In the community PR, the classes of the `s_text_cover` snippet have been
fixed.
This commit adapts the customizations to these class changes.
task-3665300
closesodoo/design-themes#944
Related: odoo/odoo#181532
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
Since the redesign of some snippets, some customizations have been
broken. This commit adapts these customizations.
This commit also adjusts some spacing and font sizes.
task-4178078
Part of task-4177978
closesodoo/design-themes#947
Signed-off-by: Alice Gaudon (agau) <agau@odoo.com>
Following the reorganization of price list snippets, this commit adapts
the tour of themes that currently use them.
task-4212916
closesodoo/design-themes#942
Related: odoo/odoo#181510
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit adds a test that makes sure that inline styles do not
contain the same property several times.
task-4206845
closesodoo/design-themes#933
Related: odoo/odoo#181194
Signed-off-by: Alice Gaudon (agau) <agau@odoo.com>
*: avantgarde, beauty, bistro, buzzy, clean, cobalt, graphene, kea, yes
This commit adapts the style attribute's add/remove operations in order
to avoid ending up with the same property defined several times.
task-4206845
Part-of: odoo/design-themes#933
Related: odoo/odoo#181194
Signed-off-by: Alice Gaudon (agau) <agau@odoo.com>
This commit adds a test that verifies that a specific `separator` is
used when an `attribute` tag is used with either `add` or `remove`.
task-4206845
Part-of: odoo/design-themes#933
Related: odoo/odoo#181194
Signed-off-by: Alice Gaudon (agau) <agau@odoo.com>
Revamp the theme design and adapt its existing snippets
task-4178083
Part of task-4177975
closesodoo/design-themes#927
Signed-off-by: Alice Gaudon (agau) <agau@odoo.com>
Odoo Translation Bot