[FIX] theme_kea: add missing images

Browse Source

Commit [1] introduced new images for the theme, alongside their related
ir.attachment definition. Later, a refactoring of the theme was made at
commit [2]. During that refactoring, multiple mistakes were made. Three
image files were removed: s_image_text.jpg, s_text_image.jpg and
s_banner.jpg. Out of these 3, only one related ir.attachment was
adapted to not use the removed image anymore: s_banner. Thus this left
two dead ir.attachment pointing to images that do not exist anymore.
Note that the banner image was actually restored later at [3]. Until
there... just dead code, although it could potentially be used and crash
by custo (this is why this targets the same version as [2]). Indeed, [2]
also patched the use of those two removed images in their related
snippet by changing the related image sources directly (using a special
route of the web_editor which generates SVG).

However, in [4], we started using one of those two images (via its xmlid
/ key) in another snippet: the new image snippet. This thus break the
kea theme when using that new snippet because the ir.attachment that is
used for that image still referenced an image that was removed by [2].

[1]: https://github.com/odoo/design-themes-old/commit/66bf0fc439f8549b00cbdf2eaa2b9517b6ac9876
[2]: https://github.com/odoo/design-themes/commit/004e38398a98ba61e587bf12b8bfc5e396baa434
[3]: https://github.com/odoo/design-themes/commit/5b8e14b83dba05e23d2a20418484b56b5f3b05cc
[4]: https://github.com/odoo/odoo/commit/507b80a12574ce19bcb925d88868fb377b1c4b06

opw-3689096

closes odoo/design-themes#770

X-original-commit: 5778e692f9
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

...

This commit is contained in:

qsm-odoo

2024-02-22 13:41:14 +01:00

parent f2c3d53d52

commit c8afdd8a3d

2 changed files with 0 additions and 0 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

theme_kea/static/src/img/snippets/s_image_text.jpg

BIN

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 78 KiB

theme_kea/static/src/img/snippets/s_text_image.jpg

BIN

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 77 KiB