mirror of
https://github.com/odoo/owl.git
synced 2025-10-06 19:59:41 +07:00
Géry Debongnie
ed4ab51c17
This is a really interesting problem: there was a situation where a component would not have an event handler properly bound. The reason was that we were in a situation where the scheduler task queue was flushed at an unfortunate timing: - parent component template is rendered - subcomponent is prepared: - sub component is willStarted - it is rendered (so, fiber counter is set to 0) - scheduler task queue is flushed => we patch the DOM - the code registered in the __prepare.then(handler) is executed, which add the createHook to the vnode (but after the dom is patched) Usually, the last two steps happen in a different order, but in an environment with connected components, we sometimes flush the task queue at various moments, so some code could be executed between the end of __prepare and the registered handler. The fix is interesting: we give a callback to the __prepare function instead of registering a .then handler to the deferred. This callback is then guaranteed to be called at exactly the proper timing. Thanks seb for the hard work of finding the root cause of this issue closes #520
44 lines
1.8 KiB
Plaintext
44 lines
1.8 KiB
Plaintext
// Jest Snapshot v1, https://goo.gl/fbAQLP
|
|
|
|
exports[`RouteComponent can render simple cases 1`] = `
|
|
"function anonymous(context,extra
|
|
) {
|
|
let utils = this.constructor.utils;
|
|
let QWeb = this.constructor;
|
|
let parent = context;
|
|
let owner = context;
|
|
let result;
|
|
var h = this.h;
|
|
if (context['routeComponent']) {
|
|
const nodeKey5 = context['env'].router.currentRouteName;
|
|
//COMPONENT
|
|
let k7 = \`__8__\` + nodeKey5;
|
|
let w6 = k7 in parent.__owl__.cmap ? parent.__owl__.children[parent.__owl__.cmap[k7]] : false;
|
|
let vn9 = {};
|
|
result = vn9;
|
|
let props6 = Object.assign({}, context['env'].router.currentParams);
|
|
if (w6 && w6.__owl__.currentFiber && !w6.__owl__.vnode) {
|
|
w6.destroy();
|
|
w6 = false;
|
|
}
|
|
if (w6) {
|
|
w6.__updateProps(props6, extra.fiber, undefined, undefined);
|
|
let pvnode = w6.__owl__.pvnode;
|
|
utils.defineProxy(vn9, pvnode);
|
|
} else {
|
|
let componentKey6 = \`routeComponent\`;
|
|
let W6 = context.constructor.components[componentKey6] || QWeb.components[componentKey6]|| context['routeComponent'];
|
|
if (!W6) {throw new Error('Cannot find the definition of component \\"' + componentKey6 + '\\"')}
|
|
w6 = new W6(parent, props6);
|
|
parent.__owl__.cmap[k7] = w6.__owl__.id;
|
|
let fiber = w6.__prepare(extra.fiber, undefined, undefined, () => { const vnode = fiber.vnode; pvnode.sel = vnode.sel; });
|
|
let pvnode = h('dummy', {key: k7, hook: {remove() {},destroy(vn) {w6.destroy();}}});
|
|
utils.defineProxy(vn9, pvnode);
|
|
w6.__owl__.pvnode = pvnode;
|
|
}
|
|
w6.__owl__.parentLastFiberId = extra.fiber.id;
|
|
}
|
|
return result;
|
|
}"
|
|
`;
|