mirror of
https://github.com/odoo/owl.git
synced 2025-10-06 19:59:41 +07:00
[FIX] component: concurrency issue with cancelled fiber
Since ee956a197, the rendering is skipped if the currentFiber is
completed. Unfortunately, cancelled fibers remain set in __owl__,
so when a fiber is cancelled, subsequent calls to render are
skipped.
It would be nice to reset __owl__.currentFiber to null when the
fiber is cancelled, but when trying to do so, a lot of tests fail.
Part of issue #622
Closes #665
This commit is contained in:
committed by
Géry Debongnie
parent
afa36f52a0
commit
f5d019bb69
@@ -1366,6 +1366,27 @@ describe("async rendering", () => {
|
||||
await prom;
|
||||
});
|
||||
|
||||
test("concurrent renderings scenario 17", async () => {
|
||||
class Parent extends Component {
|
||||
static template = xml`<span><t t-esc="state.value"/></span>`;
|
||||
state = useState({ value: 1 });
|
||||
}
|
||||
|
||||
const parent = new Parent();
|
||||
await parent.mount(fixture);
|
||||
expect(fixture.innerHTML).toBe("<span>1</span>");
|
||||
|
||||
parent.state.value = 2;
|
||||
parent.__owl__.currentFiber!.cancel();
|
||||
|
||||
parent.state.value = 3; // update value directly
|
||||
await nextTick();
|
||||
expect(fixture.innerHTML).toBe("<span>3</span>");
|
||||
|
||||
parent.state.value = 4; // update value after a tick
|
||||
expect(fixture.innerHTML).toBe("<span>4</span>");
|
||||
});
|
||||
|
||||
test("change state and call manually render: no unnecessary rendering", async () => {
|
||||
class Widget extends Component {
|
||||
static template = xml`<div><t t-esc="state.val"/></div>`;
|
||||
|
||||
Reference in New Issue
Block a user