From a6529ea67b0ef5e011384e4abbd76274a9659a2a Mon Sep 17 00:00:00 2001 From: qsm-odoo Date: Mon, 27 Sep 2021 11:44:58 +0000 Subject: [PATCH] [FIX] *: remove yiq threshold overrides Many themes were overriding the yiq threshold, thus having an impact on which of the dark or light text is used over a particuler background by default. This is a tricky value to change and only made some sense when the Odoo themes were defining their own color palettes. Now that all palettes can be used in all themes, it makes no sense to change the yiq threshold as it induces inconsistent behavior for a same palette used in different themes. Besides, leaving the value by default is most of the time what you want and when it is not entirely correct, the user has full control over the color combination text colors anyway. task-2655730 closes odoo/design-themes#507 X-original-commit: f244035809b8744c6b230e62f4e6a2fb3ba41bce Signed-off-by: Quentin Smetz (qsm) --- theme_anelusia/static/src/scss/bootstrap_overridden.scss | 3 --- theme_aviato/static/src/scss/bootstrap_overridden.scss | 3 --- theme_bistro/static/src/scss/bootstrap_overridden.scss | 3 --- theme_bookstore/static/src/scss/bootstrap_overridden.scss | 5 ----- theme_enark/static/src/scss/bootstrap_overridden.scss | 7 ------- theme_kiddo/static/src/scss/bootstrap_overridden.scss | 5 ----- theme_nano/static/src/scss/bootstrap_overridden.scss | 3 --- theme_notes/static/src/scss/bootstrap_overridden.scss | 5 ----- theme_paptic/static/src/scss/bootstrap_overridden.scss | 7 ------- theme_treehouse/static/src/scss/bootstrap_overridden.scss | 3 --- theme_zap/static/src/scss/bootstrap_overridden.scss | 3 --- 11 files changed, 47 deletions(-) diff --git a/theme_anelusia/static/src/scss/bootstrap_overridden.scss b/theme_anelusia/static/src/scss/bootstrap_overridden.scss index 69a4a59b0..15ab6da2a 100644 --- a/theme_anelusia/static/src/scss/bootstrap_overridden.scss +++ b/theme_anelusia/static/src/scss/bootstrap_overridden.scss @@ -2,9 +2,6 @@ // Bootstrap //------------------------------------------------------------------------------// -// The yiq lightness value that determines when the lightness of color changes from "dark" to "light". Acceptable values are between 0 and 255. -$yiq-contrasted-threshold: 200 !default; - // Spacing // // Control the default styling of most Bootstrap elements by modifying these diff --git a/theme_aviato/static/src/scss/bootstrap_overridden.scss b/theme_aviato/static/src/scss/bootstrap_overridden.scss index a1eb0c50b..d4ec400cc 100644 --- a/theme_aviato/static/src/scss/bootstrap_overridden.scss +++ b/theme_aviato/static/src/scss/bootstrap_overridden.scss @@ -2,9 +2,6 @@ // Bootstrap //------------------------------------------------------------------------------// -// The yiq lightness value that determines when the lightness of color changes from "dark" to "light". Acceptable values are between 0 and 255. -$yiq-contrasted-threshold: 200 !default; - // Options // // Quickly modify global styling by enabling or disabling optional features. diff --git a/theme_bistro/static/src/scss/bootstrap_overridden.scss b/theme_bistro/static/src/scss/bootstrap_overridden.scss index c7252cf04..06305361d 100644 --- a/theme_bistro/static/src/scss/bootstrap_overridden.scss +++ b/theme_bistro/static/src/scss/bootstrap_overridden.scss @@ -21,9 +21,6 @@ // Bootstrap //------------------------------------------------------------------------------// -// The yiq lightness value that determines when the lightness of color changes from "dark" to "light". Acceptable values are between 0 and 255. -$yiq-contrasted-threshold: 200 !default; - // Options // // Quickly modify global styling by enabling or disabling optional features. diff --git a/theme_bookstore/static/src/scss/bootstrap_overridden.scss b/theme_bookstore/static/src/scss/bootstrap_overridden.scss index 1398838c4..e69de29bb 100644 --- a/theme_bookstore/static/src/scss/bootstrap_overridden.scss +++ b/theme_bookstore/static/src/scss/bootstrap_overridden.scss @@ -1,5 +0,0 @@ -// Colors - -// The yiq lightness value that determines when the lightness of color changes from "dark" to "light". -// Acceptable values are between 0 and 255. -$yiq-contrasted-threshold: 140 !default; diff --git a/theme_enark/static/src/scss/bootstrap_overridden.scss b/theme_enark/static/src/scss/bootstrap_overridden.scss index e8af44948..de677dda6 100644 --- a/theme_enark/static/src/scss/bootstrap_overridden.scss +++ b/theme_enark/static/src/scss/bootstrap_overridden.scss @@ -1,10 +1,3 @@ -// Colors - -// The yiq lightness value that determines when the lightness of color changes from "dark" to "light". -// Acceptable values are between 0 and 255. -$yiq-contrasted-threshold: 150 !default; - - // Components // // Define common padding and border radius sizes and more. diff --git a/theme_kiddo/static/src/scss/bootstrap_overridden.scss b/theme_kiddo/static/src/scss/bootstrap_overridden.scss index c41bf19c6..fc5bf4ebc 100644 --- a/theme_kiddo/static/src/scss/bootstrap_overridden.scss +++ b/theme_kiddo/static/src/scss/bootstrap_overridden.scss @@ -1,8 +1,3 @@ -// The yiq lightness value that determines when the lightness of color changes from "dark" to "light". -// Acceptable values are between 0 and 255. - -$yiq-contrasted-threshold: 150 !default; - // Shadow $box-shadow-sm: 0 0 .3125rem rgba(0,0,0,.25) !default; diff --git a/theme_nano/static/src/scss/bootstrap_overridden.scss b/theme_nano/static/src/scss/bootstrap_overridden.scss index 2a466697e..56b9e6e1d 100644 --- a/theme_nano/static/src/scss/bootstrap_overridden.scss +++ b/theme_nano/static/src/scss/bootstrap_overridden.scss @@ -63,9 +63,6 @@ // Bootstrap //------------------------------------------------------------------------------// -// The yiq lightness value that determines when the lightness of color changes from "dark" to "light". Acceptable values are between 0 and 255. -$yiq-contrasted-threshold: 200 !default; - // Typography // // Font, line-height, and color for body text, headings, and more. diff --git a/theme_notes/static/src/scss/bootstrap_overridden.scss b/theme_notes/static/src/scss/bootstrap_overridden.scss index 94ef44996..e2ffbec9c 100644 --- a/theme_notes/static/src/scss/bootstrap_overridden.scss +++ b/theme_notes/static/src/scss/bootstrap_overridden.scss @@ -1,8 +1,3 @@ -// Colors - -// The yiq lightness value that determines when the lightness of color changes from "dark" to "light". Acceptable values are between 0 and 255. -$yiq-contrasted-threshold: 200 !default; - // Shadows $box-shadow-sm: 0 0 .3125rem rgba(0,0,0,.25) !default; diff --git a/theme_paptic/static/src/scss/bootstrap_overridden.scss b/theme_paptic/static/src/scss/bootstrap_overridden.scss index e1b2b9aa8..16767dc7a 100644 --- a/theme_paptic/static/src/scss/bootstrap_overridden.scss +++ b/theme_paptic/static/src/scss/bootstrap_overridden.scss @@ -1,10 +1,3 @@ -//------------------------------------------------------------------------------ -// Bootstrap Overridden -//------------------------------------------------------------------------------ - -$yiq-contrasted-threshold: 170 !default; - - // Headings $headings-line-height: 1.1 !default; diff --git a/theme_treehouse/static/src/scss/bootstrap_overridden.scss b/theme_treehouse/static/src/scss/bootstrap_overridden.scss index 7d9ce5c35..3656dde7a 100644 --- a/theme_treehouse/static/src/scss/bootstrap_overridden.scss +++ b/theme_treehouse/static/src/scss/bootstrap_overridden.scss @@ -22,9 +22,6 @@ // Bootstrap //------------------------------------------------------------------------------// -// The yiq lightness value that determines when the lightness of color changes from "dark" to "light". Acceptable values are between 0 and 255. -$yiq-contrasted-threshold: 200 !default; - // Options // // Quickly modify global styling by enabling or disabling optional features. diff --git a/theme_zap/static/src/scss/bootstrap_overridden.scss b/theme_zap/static/src/scss/bootstrap_overridden.scss index d76f31a8a..a7168aa17 100644 --- a/theme_zap/static/src/scss/bootstrap_overridden.scss +++ b/theme_zap/static/src/scss/bootstrap_overridden.scss @@ -57,9 +57,6 @@ // Bootstrap //------------------------------------------------------------------------------// -// The yiq lightness value that determines when the lightness of color changes from "dark" to "light". Acceptable values are between 0 and 255. -$yiq-contrasted-threshold: 200 !default; - // Options // // Quickly modify global styling by enabling or disabling optional features.