From 44b3badbcaabcf378bbb2d1941d2e92b3e6ac316 Mon Sep 17 00:00:00 2001 From: Benjamin Vray Date: Fri, 17 Mar 2023 15:31:49 +0000 Subject: [PATCH] [FIX] theme_*: remove flip classes from theme snippets Initially, the background shapes were flipped using only CSS. This was done by adding the classes 'o_we_flip_x' or 'o_we_flip_y' to a shape to flip it. However, this system caused issues as it sometimes left a gap between two connected shapes. As a result, the system was changed with this commit [1], and the classes 'o_we_flip_x' and 'o_we_flip_y' were no longer used from this point on. Despite this change, in our themes, we continued to use these obsolete classes to define whether a shape should be flipped or not. This commit addresses this by removing all instances of 'o_we_flip_x' and 'o_we_flip_y' classes that were still being used in theme snippets and replacing them with the new system, where flipping is defined as a parameter in the background image URL. Note that in stable versions where we cannot modify theme snippets, we have added code to automatically adapt the shapes to the new system (in this commit [2]). [1]: https://github.com/odoo/odoo/commit/42b3ad10e0b32b7fc72f801e2c67d6baf938c566 [2]: https://github.com/odoo/odoo/commit/256ff539afe331544ccb58848f1ecd0eecbe4daa task-2824607 closes odoo/design-themes#639 Signed-off-by: Quentin Smetz (qsm) --- theme_artists/views/snippets/s_banner.xml | 2 +- theme_artists/views/snippets/s_call_to_action.xml | 2 +- theme_artists/views/snippets/s_carousel.xml | 2 +- theme_artists/views/snippets/s_color_blocks_2.xml | 2 +- theme_artists/views/snippets/s_numbers.xml | 2 +- theme_artists/views/snippets/s_parallax.xml | 2 +- theme_avantgarde/views/customizations.xml | 2 +- theme_aviato/views/snippets/s_cover.xml | 2 +- theme_beauty/views/snippets/s_company_team.xml | 2 +- theme_beauty/views/snippets/s_picture.xml | 2 +- theme_beauty/views/snippets/s_title.xml | 2 +- theme_bewise/views/customizations.xml | 6 +++--- theme_bistro/views/snippets/s_banner.xml | 2 +- theme_bookstore/views/snippets/s_call_to_action.xml | 2 +- theme_bookstore/views/snippets/s_product_catalog.xml | 2 +- theme_buzzy/views/snippets/s_color_blocks_2.xml | 2 +- theme_clean/views/snippets/s_call_to_action.xml | 2 +- theme_clean/views/snippets/s_comparisons.xml | 2 +- theme_cobalt/views/customizations.xml | 6 +++--- theme_graphene/views/customizations.xml | 4 ++-- theme_kea/views/snippets/s_image_text.xml | 2 +- theme_kea/views/snippets/s_picture.xml | 2 +- theme_kea/views/snippets/s_text_image.xml | 2 +- theme_kiddo/views/snippets/s_banner.xml | 2 +- theme_kiddo/views/snippets/s_image_text.xml | 2 +- theme_kiddo/views/snippets/s_picture.xml | 4 ++-- theme_kiddo/views/snippets/s_text_image.xml | 2 +- theme_kiddo/views/snippets/s_three_columns.xml | 2 +- theme_loftspace/views/snippets/s_color_blocks_2.xml | 2 +- theme_loftspace/views/snippets/s_image_text.xml | 2 +- theme_loftspace/views/snippets/s_numbers.xml | 2 +- theme_monglia/views/customizations.xml | 2 +- theme_nano/views/snippets/s_cover.xml | 2 +- theme_nano/views/snippets/s_parallax.xml | 2 +- theme_notes/views/snippets/s_banner.xml | 2 +- theme_notes/views/snippets/s_carousel.xml | 4 ++-- theme_notes/views/snippets/s_media_list.xml | 2 +- theme_odoo_experts/views/snippets/s_company_team.xml | 2 +- theme_odoo_experts/views/snippets/s_picture.xml | 2 +- theme_odoo_experts/views/snippets/s_text_image.xml | 2 +- theme_orchid/views/snippets/s_image_text.xml | 2 +- theme_orchid/views/snippets/s_text_image.xml | 2 +- theme_paptic/views/customizations.xml | 12 ++++++------ theme_real_estate/views/snippets/s_banner.xml | 2 +- theme_vehicle/views/customizations.xml | 2 +- theme_yes/views/snippets/s_image_gallery.xml | 4 ++-- theme_zap/views/snippets/s_banner.xml | 2 +- 47 files changed, 60 insertions(+), 60 deletions(-) diff --git a/theme_artists/views/snippets/s_banner.xml b/theme_artists/views/snippets/s_banner.xml index bd93fadc0..4d2c1b2b8 100644 --- a/theme_artists/views/snippets/s_banner.xml +++ b/theme_artists/views/snippets/s_banner.xml @@ -10,7 +10,7 @@
-
+
diff --git a/theme_artists/views/snippets/s_call_to_action.xml b/theme_artists/views/snippets/s_call_to_action.xml index a014872da..98e51f8c9 100644 --- a/theme_artists/views/snippets/s_call_to_action.xml +++ b/theme_artists/views/snippets/s_call_to_action.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_artists/views/snippets/s_carousel.xml b/theme_artists/views/snippets/s_carousel.xml index 62b76a57a..56de5dd48 100644 --- a/theme_artists/views/snippets/s_carousel.xml +++ b/theme_artists/views/snippets/s_carousel.xml @@ -31,7 +31,7 @@
-
+
diff --git a/theme_artists/views/snippets/s_color_blocks_2.xml b/theme_artists/views/snippets/s_color_blocks_2.xml index cd7dfca60..543573899 100644 --- a/theme_artists/views/snippets/s_color_blocks_2.xml +++ b/theme_artists/views/snippets/s_color_blocks_2.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_artists/views/snippets/s_numbers.xml b/theme_artists/views/snippets/s_numbers.xml index d9e20d19e..d25e8526a 100644 --- a/theme_artists/views/snippets/s_numbers.xml +++ b/theme_artists/views/snippets/s_numbers.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_artists/views/snippets/s_parallax.xml b/theme_artists/views/snippets/s_parallax.xml index 2026e1b5b..8101ec2f2 100644 --- a/theme_artists/views/snippets/s_parallax.xml +++ b/theme_artists/views/snippets/s_parallax.xml @@ -12,7 +12,7 @@ -
+
diff --git a/theme_avantgarde/views/customizations.xml b/theme_avantgarde/views/customizations.xml index e1af768a7..46b13381f 100644 --- a/theme_avantgarde/views/customizations.xml +++ b/theme_avantgarde/views/customizations.xml @@ -11,7 +11,7 @@ -
+
diff --git a/theme_aviato/views/snippets/s_cover.xml b/theme_aviato/views/snippets/s_cover.xml index 5d461e4c1..399bbdc6c 100644 --- a/theme_aviato/views/snippets/s_cover.xml +++ b/theme_aviato/views/snippets/s_cover.xml @@ -12,7 +12,7 @@ -
+
diff --git a/theme_beauty/views/snippets/s_company_team.xml b/theme_beauty/views/snippets/s_company_team.xml index 102fc7e18..75d8443cc 100644 --- a/theme_beauty/views/snippets/s_company_team.xml +++ b/theme_beauty/views/snippets/s_company_team.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_beauty/views/snippets/s_picture.xml b/theme_beauty/views/snippets/s_picture.xml index d4bdf8ff1..752940d02 100644 --- a/theme_beauty/views/snippets/s_picture.xml +++ b/theme_beauty/views/snippets/s_picture.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_beauty/views/snippets/s_title.xml b/theme_beauty/views/snippets/s_title.xml index 1bdef7d1b..f12326c8c 100644 --- a/theme_beauty/views/snippets/s_title.xml +++ b/theme_beauty/views/snippets/s_title.xml @@ -13,7 +13,7 @@ -
+
diff --git a/theme_bewise/views/customizations.xml b/theme_bewise/views/customizations.xml index eacd84b4e..6ea16fa2c 100644 --- a/theme_bewise/views/customizations.xml +++ b/theme_bewise/views/customizations.xml @@ -46,7 +46,7 @@
-
+
@@ -125,7 +125,7 @@ {"shape":"web_editor/Blobs/11","flip":["x"]} -
+
Faculties @@ -162,7 +162,7 @@ -
+
diff --git a/theme_bistro/views/snippets/s_banner.xml b/theme_bistro/views/snippets/s_banner.xml index e49c692f0..41752cbbc 100644 --- a/theme_bistro/views/snippets/s_banner.xml +++ b/theme_bistro/views/snippets/s_banner.xml @@ -11,7 +11,7 @@ -
+
diff --git a/theme_bookstore/views/snippets/s_call_to_action.xml b/theme_bookstore/views/snippets/s_call_to_action.xml index 61c90a797..5ab36b926 100644 --- a/theme_bookstore/views/snippets/s_call_to_action.xml +++ b/theme_bookstore/views/snippets/s_call_to_action.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_bookstore/views/snippets/s_product_catalog.xml b/theme_bookstore/views/snippets/s_product_catalog.xml index 1de3707af..22375fca0 100644 --- a/theme_bookstore/views/snippets/s_product_catalog.xml +++ b/theme_bookstore/views/snippets/s_product_catalog.xml @@ -10,7 +10,7 @@
-
+
diff --git a/theme_buzzy/views/snippets/s_color_blocks_2.xml b/theme_buzzy/views/snippets/s_color_blocks_2.xml index 6d1229fb5..2c0c8d7bf 100644 --- a/theme_buzzy/views/snippets/s_color_blocks_2.xml +++ b/theme_buzzy/views/snippets/s_color_blocks_2.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_clean/views/snippets/s_call_to_action.xml b/theme_clean/views/snippets/s_call_to_action.xml index e3776c5a7..df17f2b52 100644 --- a/theme_clean/views/snippets/s_call_to_action.xml +++ b/theme_clean/views/snippets/s_call_to_action.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_clean/views/snippets/s_comparisons.xml b/theme_clean/views/snippets/s_comparisons.xml index db41e4330..3a7bf2f67 100644 --- a/theme_clean/views/snippets/s_comparisons.xml +++ b/theme_clean/views/snippets/s_comparisons.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_cobalt/views/customizations.xml b/theme_cobalt/views/customizations.xml index 033e1bd83..4244c87f5 100644 --- a/theme_cobalt/views/customizations.xml +++ b/theme_cobalt/views/customizations.xml @@ -9,7 +9,7 @@ {"shape":"web_editor/Origins/11_001","flip":["y"]} -
+
@@ -141,7 +141,7 @@ {"shape":"web_editor/Bold/01","flip":["x"]} -
+

Latest projects

@@ -163,7 +163,7 @@ {"shape":"web_editor/Bold/01","flip":["y"]}
-
+
diff --git a/theme_graphene/views/customizations.xml b/theme_graphene/views/customizations.xml index d94f12f7d..4b5ce2d2c 100644 --- a/theme_graphene/views/customizations.xml +++ b/theme_graphene/views/customizations.xml @@ -44,7 +44,7 @@ {"shape":"web_editor/Origins/02_001","flip":["x","y"]} -
+

Unique experiences to drive engagement

@@ -219,7 +219,7 @@ {"shape":"web_editor/Origins/06_001","flip":["x"]}
-
+
Start Now diff --git a/theme_kea/views/snippets/s_image_text.xml b/theme_kea/views/snippets/s_image_text.xml index d46774cf1..6d5e16e67 100644 --- a/theme_kea/views/snippets/s_image_text.xml +++ b/theme_kea/views/snippets/s_image_text.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_kea/views/snippets/s_picture.xml b/theme_kea/views/snippets/s_picture.xml index 7121384af..a2a35fbf4 100644 --- a/theme_kea/views/snippets/s_picture.xml +++ b/theme_kea/views/snippets/s_picture.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_kea/views/snippets/s_text_image.xml b/theme_kea/views/snippets/s_text_image.xml index 8c32d65bd..302d89da4 100644 --- a/theme_kea/views/snippets/s_text_image.xml +++ b/theme_kea/views/snippets/s_text_image.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_kiddo/views/snippets/s_banner.xml b/theme_kiddo/views/snippets/s_banner.xml index ee6cc4bbb..2bd65ba16 100644 --- a/theme_kiddo/views/snippets/s_banner.xml +++ b/theme_kiddo/views/snippets/s_banner.xml @@ -16,7 +16,7 @@
-
+
diff --git a/theme_kiddo/views/snippets/s_image_text.xml b/theme_kiddo/views/snippets/s_image_text.xml index 6ad590733..0b1b94b7a 100644 --- a/theme_kiddo/views/snippets/s_image_text.xml +++ b/theme_kiddo/views/snippets/s_image_text.xml @@ -10,7 +10,7 @@ -
+
diff --git a/theme_kiddo/views/snippets/s_picture.xml b/theme_kiddo/views/snippets/s_picture.xml index 337506c0f..e54694b6b 100644 --- a/theme_kiddo/views/snippets/s_picture.xml +++ b/theme_kiddo/views/snippets/s_picture.xml @@ -5,12 +5,12 @@ - {"shape":"web_editor/Origins/16"} + {"shape":"web_editor/Origins/16","flip":["x"]} -
+
diff --git a/theme_kiddo/views/snippets/s_text_image.xml b/theme_kiddo/views/snippets/s_text_image.xml index 36f2dbc6d..efb1b6bac 100644 --- a/theme_kiddo/views/snippets/s_text_image.xml +++ b/theme_kiddo/views/snippets/s_text_image.xml @@ -10,7 +10,7 @@ -
+
diff --git a/theme_kiddo/views/snippets/s_three_columns.xml b/theme_kiddo/views/snippets/s_three_columns.xml index 2fa0754ec..30f94b4b8 100644 --- a/theme_kiddo/views/snippets/s_three_columns.xml +++ b/theme_kiddo/views/snippets/s_three_columns.xml @@ -10,7 +10,7 @@ -
+
diff --git a/theme_loftspace/views/snippets/s_color_blocks_2.xml b/theme_loftspace/views/snippets/s_color_blocks_2.xml index c84514803..7c51cb0fe 100644 --- a/theme_loftspace/views/snippets/s_color_blocks_2.xml +++ b/theme_loftspace/views/snippets/s_color_blocks_2.xml @@ -16,7 +16,7 @@ {'shape':'web_editor/Airy/04_001','flip':['x']} -
+
diff --git a/theme_loftspace/views/snippets/s_image_text.xml b/theme_loftspace/views/snippets/s_image_text.xml index 8ebe9e722..62c527f01 100644 --- a/theme_loftspace/views/snippets/s_image_text.xml +++ b/theme_loftspace/views/snippets/s_image_text.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_loftspace/views/snippets/s_numbers.xml b/theme_loftspace/views/snippets/s_numbers.xml index 2a2a5578d..11c3206f2 100644 --- a/theme_loftspace/views/snippets/s_numbers.xml +++ b/theme_loftspace/views/snippets/s_numbers.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_monglia/views/customizations.xml b/theme_monglia/views/customizations.xml index d6da0aa52..2506ff144 100644 --- a/theme_monglia/views/customizations.xml +++ b/theme_monglia/views/customizations.xml @@ -99,7 +99,7 @@ {"shape":"web_editor/Blocks/04","flip":["y"]} -
+
diff --git a/theme_nano/views/snippets/s_cover.xml b/theme_nano/views/snippets/s_cover.xml index 5d94cdf3b..2b9299fbb 100644 --- a/theme_nano/views/snippets/s_cover.xml +++ b/theme_nano/views/snippets/s_cover.xml @@ -10,7 +10,7 @@ background-image: url('/web/image/website.s_cover_default_image'); background-position: 50% 0; -
+
diff --git a/theme_nano/views/snippets/s_parallax.xml b/theme_nano/views/snippets/s_parallax.xml index a5fdae5b1..3312d270e 100644 --- a/theme_nano/views/snippets/s_parallax.xml +++ b/theme_nano/views/snippets/s_parallax.xml @@ -8,7 +8,7 @@ {"shape":"web_editor/Rainy/10", "flip":["x","y"]} -
+
diff --git a/theme_notes/views/snippets/s_banner.xml b/theme_notes/views/snippets/s_banner.xml index ecb2042ef..5fde5fc86 100644 --- a/theme_notes/views/snippets/s_banner.xml +++ b/theme_notes/views/snippets/s_banner.xml @@ -10,7 +10,7 @@
-
+
diff --git a/theme_notes/views/snippets/s_carousel.xml b/theme_notes/views/snippets/s_carousel.xml index e05882a7a..3ab9ba0b9 100644 --- a/theme_notes/views/snippets/s_carousel.xml +++ b/theme_notes/views/snippets/s_carousel.xml @@ -17,7 +17,7 @@ -
+
@@ -51,7 +51,7 @@ -
+
diff --git a/theme_notes/views/snippets/s_media_list.xml b/theme_notes/views/snippets/s_media_list.xml index 1c625749c..aa2f1e948 100644 --- a/theme_notes/views/snippets/s_media_list.xml +++ b/theme_notes/views/snippets/s_media_list.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_odoo_experts/views/snippets/s_company_team.xml b/theme_odoo_experts/views/snippets/s_company_team.xml index 7e53e7f62..6d304c791 100644 --- a/theme_odoo_experts/views/snippets/s_company_team.xml +++ b/theme_odoo_experts/views/snippets/s_company_team.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_odoo_experts/views/snippets/s_picture.xml b/theme_odoo_experts/views/snippets/s_picture.xml index b4a597380..12a24a1a5 100644 --- a/theme_odoo_experts/views/snippets/s_picture.xml +++ b/theme_odoo_experts/views/snippets/s_picture.xml @@ -11,7 +11,7 @@
-
+
diff --git a/theme_odoo_experts/views/snippets/s_text_image.xml b/theme_odoo_experts/views/snippets/s_text_image.xml index a23b27a06..9ea522e3e 100644 --- a/theme_odoo_experts/views/snippets/s_text_image.xml +++ b/theme_odoo_experts/views/snippets/s_text_image.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_orchid/views/snippets/s_image_text.xml b/theme_orchid/views/snippets/s_image_text.xml index 5c4359339..6021dc401 100644 --- a/theme_orchid/views/snippets/s_image_text.xml +++ b/theme_orchid/views/snippets/s_image_text.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_orchid/views/snippets/s_text_image.xml b/theme_orchid/views/snippets/s_text_image.xml index c8ce350a1..dc0789a08 100644 --- a/theme_orchid/views/snippets/s_text_image.xml +++ b/theme_orchid/views/snippets/s_text_image.xml @@ -9,7 +9,7 @@ -
+
diff --git a/theme_paptic/views/customizations.xml b/theme_paptic/views/customizations.xml index 11bfd6b87..caff5bd4c 100644 --- a/theme_paptic/views/customizations.xml +++ b/theme_paptic/views/customizations.xml @@ -21,7 +21,7 @@ -
+
@@ -73,7 +73,7 @@ -
+
@@ -303,7 +303,7 @@ -
+
@@ -345,7 +345,7 @@ {"shape":"web_editor/Blocks/03","flip":["y"]} -
+
@@ -353,7 +353,7 @@ {"shape":"web_editor/Blocks/03","flip":["x","y"]} -
+
@@ -390,7 +390,7 @@ -
+
diff --git a/theme_real_estate/views/snippets/s_banner.xml b/theme_real_estate/views/snippets/s_banner.xml index ec4051f1e..b621bee72 100644 --- a/theme_real_estate/views/snippets/s_banner.xml +++ b/theme_real_estate/views/snippets/s_banner.xml @@ -10,7 +10,7 @@
-
+
diff --git a/theme_vehicle/views/customizations.xml b/theme_vehicle/views/customizations.xml index 053f9e29c..f9b21b5da 100644 --- a/theme_vehicle/views/customizations.xml +++ b/theme_vehicle/views/customizations.xml @@ -7,7 +7,7 @@ {"shape":"web_editor/Origins/18","flip":["x"]} -
+
diff --git a/theme_yes/views/snippets/s_image_gallery.xml b/theme_yes/views/snippets/s_image_gallery.xml index 946c3302f..4fcd3dfaa 100644 --- a/theme_yes/views/snippets/s_image_gallery.xml +++ b/theme_yes/views/snippets/s_image_gallery.xml @@ -5,11 +5,11 @@ - {"shape":"web_editor/Floats/12", "flip":["x","y"]} + {"shape":"web_editor/Floats/12", "flip":[]} -
+
diff --git a/theme_zap/views/snippets/s_banner.xml b/theme_zap/views/snippets/s_banner.xml index 57e1a7f52..c54cb69bd 100644 --- a/theme_zap/views/snippets/s_banner.xml +++ b/theme_zap/views/snippets/s_banner.xml @@ -8,7 +8,7 @@ {"shape":"web_editor/Origins/04_001","flip":["y"]} -
+