From 3cc5d6b655c5dc4389f51a588d374dcc3b2bb691 Mon Sep 17 00:00:00 2001 From: "Chrysanthe (chgo)" Date: Sun, 22 Sep 2024 17:38:16 +0200 Subject: [PATCH] [FIX] theme_*: fix `s_big_number` wrong implementation *: anelusia, artists, avantgarde, aviato, beauty, bewise, bistro, bookstore, buzzy, clean, cobalt, enark, graphene, kea, kiddo, loftspace, monglia, nano, notes, odoo_experts, orchid, paptic, real_estate, treehouse, vehicle, yes, zap This commit aims to fix a wrong implementation of gradients on the `s_big_number` snippet within the context of the web editor. Prior to this commit, the `s_big_number` snippet was using a gradient composed of the right color, but being declared as `RGB` values. While this is working as expected and looking like it uses the right `--o-color-*`, it's indeed working with the specific color applied in first place. If a user changes the color palette of the website, the snippet will look terrible as it doesn't adapt to the new palette. This commit fixes the issue by using the right implementation with CSS variables. It also reviews a wrong structure using `
` while it should use the right html tag. task-4202371 closes odoo/design-themes#930 Related: odoo/odoo#180983 Signed-off-by: Benjamin Vray (bvr) --- theme_anelusia/views/snippets/s_big_number.xml | 6 +++--- theme_artists/views/snippets/s_big_number.xml | 8 ++++---- theme_avantgarde/views/customizations.xml | 6 +++--- theme_aviato/views/snippets/s_big_number.xml | 8 ++++---- theme_beauty/views/snippets/s_big_number.xml | 8 ++++---- theme_bewise/views/customizations.xml | 6 +++--- theme_bistro/views/snippets/s_big_number.xml | 6 +++--- theme_bookstore/views/snippets/s_big_number.xml | 2 +- theme_buzzy/views/snippets/s_big_number.xml | 5 +---- theme_clean/views/snippets/s_big_number.xml | 5 +---- theme_cobalt/views/customizations.xml | 2 +- theme_enark/views/snippets/s_big_number.xml | 8 ++++---- theme_graphene/views/customizations.xml | 5 +---- theme_kea/views/snippets/s_big_number.xml | 4 ++-- theme_kiddo/views/snippets/s_big_number.xml | 4 ++-- theme_loftspace/views/snippets/s_big_number.xml | 6 +++--- theme_monglia/views/customizations.xml | 8 ++++---- theme_nano/views/snippets/s_big_number.xml | 6 +++--- theme_notes/views/snippets/s_big_number.xml | 6 +++--- theme_odoo_experts/views/snippets/s_big_number.xml | 4 ++-- theme_orchid/views/snippets/s_big_number.xml | 4 ++-- theme_paptic/views/customizations.xml | 6 +++--- theme_real_estate/views/snippets/s_big_number.xml | 6 +++--- theme_treehouse/views/snippets/s_big_number.xml | 6 +++--- theme_vehicle/views/customizations.xml | 6 +++--- theme_yes/views/snippets/s_big_number.xml | 6 +++--- theme_zap/views/snippets/s_big_number.xml | 4 ++-- 27 files changed, 71 insertions(+), 80 deletions(-) diff --git a/theme_anelusia/views/snippets/s_big_number.xml b/theme_anelusia/views/snippets/s_big_number.xml index 4fd3a4f50..97d4f0b54 100644 --- a/theme_anelusia/views/snippets/s_big_number.xml +++ b/theme_anelusia/views/snippets/s_big_number.xml @@ -13,12 +13,12 @@ - - + + 100+ - + happy customers diff --git a/theme_artists/views/snippets/s_big_number.xml b/theme_artists/views/snippets/s_big_number.xml index c473da6f0..b43940d64 100644 --- a/theme_artists/views/snippets/s_big_number.xml +++ b/theme_artists/views/snippets/s_big_number.xml @@ -13,15 +13,15 @@ - + - - + + 250+ - + songs released diff --git a/theme_avantgarde/views/customizations.xml b/theme_avantgarde/views/customizations.xml index b4968e4c7..2c27a081f 100644 --- a/theme_avantgarde/views/customizations.xml +++ b/theme_avantgarde/views/customizations.xml @@ -603,12 +603,12 @@ - - + + 50+ - + projects shipped diff --git a/theme_aviato/views/snippets/s_big_number.xml b/theme_aviato/views/snippets/s_big_number.xml index b01ba540a..99d24ef84 100644 --- a/theme_aviato/views/snippets/s_big_number.xml +++ b/theme_aviato/views/snippets/s_big_number.xml @@ -14,13 +14,13 @@ - + - - 100+ + + 100+ - + destinations available diff --git a/theme_beauty/views/snippets/s_big_number.xml b/theme_beauty/views/snippets/s_big_number.xml index 4b1246c77..7efefd07c 100644 --- a/theme_beauty/views/snippets/s_big_number.xml +++ b/theme_beauty/views/snippets/s_big_number.xml @@ -14,13 +14,13 @@ - + - - 200+ + + 200+ - + happy customers diff --git a/theme_bewise/views/customizations.xml b/theme_bewise/views/customizations.xml index 3e40c87d9..a5624efb4 100644 --- a/theme_bewise/views/customizations.xml +++ b/theme_bewise/views/customizations.xml @@ -907,10 +907,10 @@ - - 60+ + + 60+ - + academic programs available diff --git a/theme_bistro/views/snippets/s_big_number.xml b/theme_bistro/views/snippets/s_big_number.xml index 4d505df4d..93f872545 100644 --- a/theme_bistro/views/snippets/s_big_number.xml +++ b/theme_bistro/views/snippets/s_big_number.xml @@ -13,14 +13,14 @@ - + 350+ - + 350+ - + happy guests served diff --git a/theme_bookstore/views/snippets/s_big_number.xml b/theme_bookstore/views/snippets/s_big_number.xml index ff93e20ee..460361c5e 100644 --- a/theme_bookstore/views/snippets/s_big_number.xml +++ b/theme_bookstore/views/snippets/s_big_number.xml @@ -13,7 +13,7 @@ - + 90% diff --git a/theme_buzzy/views/snippets/s_big_number.xml b/theme_buzzy/views/snippets/s_big_number.xml index 57ad28177..70861c30b 100644 --- a/theme_buzzy/views/snippets/s_big_number.xml +++ b/theme_buzzy/views/snippets/s_big_number.xml @@ -14,12 +14,9 @@ - + 90% - - - diff --git a/theme_clean/views/snippets/s_big_number.xml b/theme_clean/views/snippets/s_big_number.xml index 57ad28177..70861c30b 100644 --- a/theme_clean/views/snippets/s_big_number.xml +++ b/theme_clean/views/snippets/s_big_number.xml @@ -14,12 +14,9 @@ - + 90% - - - diff --git a/theme_cobalt/views/customizations.xml b/theme_cobalt/views/customizations.xml index f55f2c58b..b2e89c76b 100644 --- a/theme_cobalt/views/customizations.xml +++ b/theme_cobalt/views/customizations.xml @@ -575,7 +575,7 @@ - + 90% diff --git a/theme_enark/views/snippets/s_big_number.xml b/theme_enark/views/snippets/s_big_number.xml index f0ae2d9e5..9b2cd036c 100644 --- a/theme_enark/views/snippets/s_big_number.xml +++ b/theme_enark/views/snippets/s_big_number.xml @@ -4,20 +4,20 @@ diff --git a/theme_graphene/views/customizations.xml b/theme_graphene/views/customizations.xml index b3cbb7afb..d44ec14f7 100644 --- a/theme_graphene/views/customizations.xml +++ b/theme_graphene/views/customizations.xml @@ -587,12 +587,9 @@ - + 90% - - - diff --git a/theme_kea/views/snippets/s_big_number.xml b/theme_kea/views/snippets/s_big_number.xml index be97bb0af..24f5c3b39 100644 --- a/theme_kea/views/snippets/s_big_number.xml +++ b/theme_kea/views/snippets/s_big_number.xml @@ -14,10 +14,10 @@ - + 80+ - + satisfied clients diff --git a/theme_kiddo/views/snippets/s_big_number.xml b/theme_kiddo/views/snippets/s_big_number.xml index 253816c78..dffa5a4b8 100644 --- a/theme_kiddo/views/snippets/s_big_number.xml +++ b/theme_kiddo/views/snippets/s_big_number.xml @@ -14,10 +14,10 @@ - + 80+ - + families trusted us diff --git a/theme_loftspace/views/snippets/s_big_number.xml b/theme_loftspace/views/snippets/s_big_number.xml index 5145e9006..b5afbbaf3 100644 --- a/theme_loftspace/views/snippets/s_big_number.xml +++ b/theme_loftspace/views/snippets/s_big_number.xml @@ -14,13 +14,13 @@ - + - + 250+ - + satisfied clients diff --git a/theme_monglia/views/customizations.xml b/theme_monglia/views/customizations.xml index ddb1e1447..94bc3d6db 100644 --- a/theme_monglia/views/customizations.xml +++ b/theme_monglia/views/customizations.xml @@ -729,15 +729,15 @@ - + - - + + 250+ - + events organized diff --git a/theme_nano/views/snippets/s_big_number.xml b/theme_nano/views/snippets/s_big_number.xml index 8e708a329..041827ffd 100644 --- a/theme_nano/views/snippets/s_big_number.xml +++ b/theme_nano/views/snippets/s_big_number.xml @@ -14,13 +14,13 @@ - + - + 250+ - + satisfied clients diff --git a/theme_notes/views/snippets/s_big_number.xml b/theme_notes/views/snippets/s_big_number.xml index 95ce9c048..981e4b67b 100644 --- a/theme_notes/views/snippets/s_big_number.xml +++ b/theme_notes/views/snippets/s_big_number.xml @@ -14,13 +14,13 @@ - + - + 20M - + Monthly listeners on streaming platforms diff --git a/theme_odoo_experts/views/snippets/s_big_number.xml b/theme_odoo_experts/views/snippets/s_big_number.xml index b91afeddf..c1af6c440 100644 --- a/theme_odoo_experts/views/snippets/s_big_number.xml +++ b/theme_odoo_experts/views/snippets/s_big_number.xml @@ -12,10 +12,10 @@ - + - + 90% diff --git a/theme_orchid/views/snippets/s_big_number.xml b/theme_orchid/views/snippets/s_big_number.xml index 95ffdb757..30f028ffe 100644 --- a/theme_orchid/views/snippets/s_big_number.xml +++ b/theme_orchid/views/snippets/s_big_number.xml @@ -13,10 +13,10 @@ - + 50+ - + varieties of flowers to choose from diff --git a/theme_paptic/views/customizations.xml b/theme_paptic/views/customizations.xml index f6296c5cb..12b520239 100644 --- a/theme_paptic/views/customizations.xml +++ b/theme_paptic/views/customizations.xml @@ -675,13 +675,13 @@ - + - + 85% - + customers satisfaction diff --git a/theme_real_estate/views/snippets/s_big_number.xml b/theme_real_estate/views/snippets/s_big_number.xml index 289899298..0730e40ba 100644 --- a/theme_real_estate/views/snippets/s_big_number.xml +++ b/theme_real_estate/views/snippets/s_big_number.xml @@ -14,13 +14,13 @@ - + - + 85% - + customers satisfaction diff --git a/theme_treehouse/views/snippets/s_big_number.xml b/theme_treehouse/views/snippets/s_big_number.xml index cc6141807..0b7353830 100644 --- a/theme_treehouse/views/snippets/s_big_number.xml +++ b/theme_treehouse/views/snippets/s_big_number.xml @@ -13,13 +13,13 @@ - + - + 1,250 - + trees planted since last year diff --git a/theme_vehicle/views/customizations.xml b/theme_vehicle/views/customizations.xml index a4d8f4f7c..c907c7929 100644 --- a/theme_vehicle/views/customizations.xml +++ b/theme_vehicle/views/customizations.xml @@ -717,12 +717,12 @@ - - + + 87% - + customer satisfaction diff --git a/theme_yes/views/snippets/s_big_number.xml b/theme_yes/views/snippets/s_big_number.xml index ca58a83da..003ee6bc4 100644 --- a/theme_yes/views/snippets/s_big_number.xml +++ b/theme_yes/views/snippets/s_big_number.xml @@ -14,13 +14,13 @@ - + - + 1,500+ - + personalized invitations created diff --git a/theme_zap/views/snippets/s_big_number.xml b/theme_zap/views/snippets/s_big_number.xml index 74af91f26..8701e4ae7 100644 --- a/theme_zap/views/snippets/s_big_number.xml +++ b/theme_zap/views/snippets/s_big_number.xml @@ -13,10 +13,10 @@ - + - + 90%