From 3b94657c598f0806ddfacaeb62c435a0807e5854 Mon Sep 17 00:00:00 2001 From: "Hubert Van de Walle (huvw)" Date: Mon, 20 Nov 2023 15:42:47 +0100 Subject: [PATCH] [FIX] theme_*: Update homepage tours Steps to reproduce ================== Run the `test_02_homepage_tour_every_theme` tour. Cause of the issue ================== There is an homepage tour for every theme. Since the owl conversion of web_tour, none of the custom theme tour were run and for every website, the default homepage tour was used instead. Some updates to those themes caused the tours to fail, but since they weren't run, no one noticed. The issue has been fixed in community: https://github.com/odoo/odoo/pull/142350 Solution ======== Since 1aa6700c986a96463165824400a9157c1db4e723, some h1 tags were replaced by h2. Since 68c68740bff7e96b9530de7d6fd4cd58145434a0, The banner has been replaced by a text cover. opw-3595512 X-original-commit: 2e263a4f6b0cdcf0390dbe752c23c0c67ac36249 Part-of: odoo/design-themes#746 --- theme_anelusia/static/src/js/tour.js | 2 +- theme_artists/static/src/js/tour.js | 2 +- theme_notes/static/src/js/tour.js | 2 +- theme_yes/static/src/js/tour.js | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/theme_anelusia/static/src/js/tour.js b/theme_anelusia/static/src/js/tour.js index a950a6e40..3fefeed85 100644 --- a/theme_anelusia/static/src/js/tour.js +++ b/theme_anelusia/static/src/js/tour.js @@ -5,7 +5,7 @@ import wTourUtils from '@website/js/tours/tour_utils'; const snippets = [ { id: 's_text_cover', - name: 'Banner', + name: 'Text Cover', }, { id: 's_images_wall', diff --git a/theme_artists/static/src/js/tour.js b/theme_artists/static/src/js/tour.js index 3ef1bd871..52a453ff7 100644 --- a/theme_artists/static/src/js/tour.js +++ b/theme_artists/static/src/js/tour.js @@ -37,7 +37,7 @@ wTourUtils.registerThemeHomepageTour("artists_tour", () => [ wTourUtils.goBackToBlocks(), wTourUtils.dragNDrop(snippets[2]), wTourUtils.dragNDrop(snippets[3]), - wTourUtils.clickOnText(snippets[3], 'h1'), + wTourUtils.clickOnText(snippets[3], 'h2'), wTourUtils.goBackToBlocks(), wTourUtils.dragNDrop(snippets[4]), wTourUtils.dragNDrop(snippets[5]), diff --git a/theme_notes/static/src/js/tour.js b/theme_notes/static/src/js/tour.js index b3237e8ba..61273768d 100644 --- a/theme_notes/static/src/js/tour.js +++ b/theme_notes/static/src/js/tour.js @@ -33,7 +33,7 @@ const snippets = [ wTourUtils.registerThemeHomepageTour("notes_tour", () => [ wTourUtils.assertCssVariable('--color-palettes-name', '"notes-1"'), wTourUtils.dragNDrop(snippets[0]), - wTourUtils.clickOnText(snippets[0], 'h1'), + wTourUtils.clickOnText(snippets[0], 'h2'), wTourUtils.goBackToBlocks(), wTourUtils.dragNDrop(snippets[1]), wTourUtils.dragNDrop(snippets[2]), diff --git a/theme_yes/static/src/js/tour.js b/theme_yes/static/src/js/tour.js index 7dd72ae33..234cccaf1 100644 --- a/theme_yes/static/src/js/tour.js +++ b/theme_yes/static/src/js/tour.js @@ -33,7 +33,7 @@ wTourUtils.registerThemeHomepageTour("yes_tour", () => [ wTourUtils.assertCssVariable('--color-palettes-name', '"yes-3"'), wTourUtils.dragNDrop(snippets[0]), wTourUtils.dragNDrop(snippets[1]), - wTourUtils.clickOnText(snippets[1], 'h1'), + wTourUtils.clickOnText(snippets[1], 'h2'), wTourUtils.goBackToBlocks(), wTourUtils.dragNDrop(snippets[2]), wTourUtils.dragNDrop(snippets[3]),