From 1aa6700c986a96463165824400a9157c1db4e723 Mon Sep 17 00:00:00 2001
From: "Guillaume (gdi)" <gdi@odoo.com>
Date: Tue, 1 Aug 2023 17:43:40 +0200
Subject: [PATCH] [IMP] theme_*: prevent abuse of h1 and use font size classes

See related community PR.

task-1958098

closes odoo/design-themes#682

Related: odoo/enterprise#44986
Related: odoo/odoo#129791
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
---
 theme_artists/views/snippets/s_title.xml      | 2 +-
 theme_avantgarde/views/customizations.xml     | 9 +++------
 theme_aviato/views/snippets/s_title.xml       | 2 +-
 theme_beauty/views/snippets/s_title.xml       | 2 +-
 theme_bistro/views/snippets/s_cover.xml       | 2 +-
 theme_bookstore/views/snippets/s_title.xml    | 2 +-
 theme_buzzy/views/snippets/s_title.xml        | 2 +-
 theme_clean/views/snippets/s_title.xml        | 2 +-
 theme_cobalt/views/customizations.xml         | 2 +-
 theme_enark/views/snippets/s_parallax.xml     | 2 +-
 theme_kiddo/views/snippets/s_cover.xml        | 2 +-
 theme_kiddo/views/snippets/s_picture.xml      | 2 +-
 theme_loftspace/views/snippets/s_title.xml    | 2 +-
 theme_monglia/views/customizations.xml        | 4 ++--
 theme_nano/views/snippets/s_cover.xml         | 2 +-
 theme_notes/views/snippets/s_carousel.xml     | 6 +++---
 theme_odoo_experts/views/snippets/s_title.xml | 2 +-
 theme_paptic/views/customizations.xml         | 2 +-
 theme_treehouse/views/snippets/s_title.xml    | 2 +-
 theme_yes/views/snippets/s_cover.xml          | 5 ++++-
 theme_yes/views/snippets/s_picture.xml        | 2 +-
 theme_yes/views/snippets/s_title.xml          | 2 +-
 22 files changed, 30 insertions(+), 30 deletions(-)

diff --git a/theme_artists/views/snippets/s_title.xml b/theme_artists/views/snippets/s_title.xml
index ed2a7ce52..7368a8975 100644
--- a/theme_artists/views/snippets/s_title.xml
+++ b/theme_artists/views/snippets/s_title.xml
@@ -13,7 +13,7 @@
         <div class="o_we_bg_filter" style="background-color: rgba(17, 13, 22, 0.85) !important;"/>
     </xpath>
     <!-- Title -->
-    <xpath expr="//h1" position="replace" mode="inner">
+    <xpath expr="//h2" position="replace" mode="inner">
         It's all about perception
     </xpath>
 </template>
diff --git a/theme_avantgarde/views/customizations.xml b/theme_avantgarde/views/customizations.xml
index 49ec2e413..747ec9ae6 100644
--- a/theme_avantgarde/views/customizations.xml
+++ b/theme_avantgarde/views/customizations.xml
@@ -9,10 +9,10 @@
     <xpath expr="//span[hasclass('s_parallax_bg')]" position="attributes">
         <attribute name="style" remove="background-position: 50% 0;" add="background-position: 50% 80%;" separator=";"/>
     </xpath>
-    <xpath expr="//font" position="attributes">
+    <xpath expr="//h1" position="attributes">
         <attribute name="class" add="text-o-color-1 text-break" separator=" "/>
     </xpath>
-    <xpath expr="//font" position="replace" mode="inner">
+    <xpath expr="//h1" position="replace" mode="inner">
         We are Avantgarde.
     </xpath>
     <xpath expr="//p" position="replace" mode="inner">
@@ -40,12 +40,9 @@
     </xpath>
     <xpath expr="//h2" position="attributes">
         <attribute name="style" remove="text-align: center;" separator=" "/>
-    </xpath>
-    <xpath expr="//font" position="attributes">
         <attribute name="class" add="text-break" separator=" "/>
-        <attribute name="style" add="font-weight: bolder;" separator=" "/>
     </xpath>
-    <xpath expr="//font" position="replace" mode="inner">
+    <xpath expr="//h2" position="replace" mode="inner">
         Design Methodology
     </xpath>
     <xpath expr="//p" position="attributes">
diff --git a/theme_aviato/views/snippets/s_title.xml b/theme_aviato/views/snippets/s_title.xml
index a14834d75..567c1e6a1 100644
--- a/theme_aviato/views/snippets/s_title.xml
+++ b/theme_aviato/views/snippets/s_title.xml
@@ -3,7 +3,7 @@
 
 <template id="s_title" inherit_id="website.s_title">
     <!-- Title -->
-    <xpath expr="//h1" position="replace" mode="inner">
+    <xpath expr="//h2" position="replace" mode="inner">
         Top Destinations
     </xpath>
     <xpath expr="//section" position="attributes">
diff --git a/theme_beauty/views/snippets/s_title.xml b/theme_beauty/views/snippets/s_title.xml
index 7f3a98594..5e26bc0e1 100644
--- a/theme_beauty/views/snippets/s_title.xml
+++ b/theme_beauty/views/snippets/s_title.xml
@@ -7,7 +7,7 @@
         <attribute name="class" add="o_cc o_cc4 pt80" remove="pt40" separator=" "/>
     </xpath>
     <!-- Title -->
-    <xpath expr="//h1" position="replace" mode="inner">
+    <xpath expr="//h2" position="replace" mode="inner">
         Close your eyes and let yourself go in the expert hands of our beauticians.
     </xpath>
 </template>
diff --git a/theme_bistro/views/snippets/s_cover.xml b/theme_bistro/views/snippets/s_cover.xml
index 2623d0dfe..d415adfd3 100644
--- a/theme_bistro/views/snippets/s_cover.xml
+++ b/theme_bistro/views/snippets/s_cover.xml
@@ -7,7 +7,7 @@
         <attribute name="style" add="background-position: 50% 100%;" remove="background-position: 50% 0;" separator=" "/>
     </xpath>
     <!-- Title -->
-    <xpath expr="//h1//font" position="replace" mode="inner">
+    <xpath expr="//h1" position="replace" mode="inner">
         Seasonal<br/> Flavors
     </xpath>
     <xpath expr="//h1" position="before">
diff --git a/theme_bookstore/views/snippets/s_title.xml b/theme_bookstore/views/snippets/s_title.xml
index f564e9326..77bb94036 100644
--- a/theme_bookstore/views/snippets/s_title.xml
+++ b/theme_bookstore/views/snippets/s_title.xml
@@ -12,7 +12,7 @@
         <div class="o_we_bg_filter bg-black-50"/>
     </xpath>
     <!-- Title -->
-    <xpath expr="//h1" position="replace" mode="inner">
+    <xpath expr="//h2" position="replace" mode="inner">
         Reading means borrowing
     </xpath>
 </template>
diff --git a/theme_buzzy/views/snippets/s_title.xml b/theme_buzzy/views/snippets/s_title.xml
index e792f16c2..02ddda373 100644
--- a/theme_buzzy/views/snippets/s_title.xml
+++ b/theme_buzzy/views/snippets/s_title.xml
@@ -7,7 +7,7 @@
         <attribute name="class" add="o_cc o_cc4 pt152 pb152 oe_img_bg o_bg_img_center" remove="pb40 pt40" separator=" "/>
     </xpath>
     <!-- Title -->
-    <xpath expr="//h1" position="replace" mode="inner">
+    <xpath expr="//h2" position="replace" mode="inner">
         Increase your productivity
     </xpath>
 </template>
diff --git a/theme_clean/views/snippets/s_title.xml b/theme_clean/views/snippets/s_title.xml
index f1c694f04..23ebab82a 100644
--- a/theme_clean/views/snippets/s_title.xml
+++ b/theme_clean/views/snippets/s_title.xml
@@ -13,7 +13,7 @@
         <div class="o_we_bg_filter bg-black-50"/>
     </xpath>
     <!-- Title -->
-    <xpath expr="//h1" position="replace" mode="inner">
+    <xpath expr="//h2" position="replace" mode="inner">
         <b>We create the perfect <br/>tailored solution for you</b>
     </xpath>
 </template>
diff --git a/theme_cobalt/views/customizations.xml b/theme_cobalt/views/customizations.xml
index 63f5fcf95..2d28f8a51 100644
--- a/theme_cobalt/views/customizations.xml
+++ b/theme_cobalt/views/customizations.xml
@@ -125,7 +125,7 @@
     <xpath expr="//section" position="attributes">
         <attribute name="class" add="pt56" remove="pt40" separator=" "/>
     </xpath>
-    <xpath expr="//h1" position="replace" mode="inner">
+    <xpath expr="//h2" position="replace" mode="inner">
         Projects
     </xpath>
 </template>
diff --git a/theme_enark/views/snippets/s_parallax.xml b/theme_enark/views/snippets/s_parallax.xml
index 73704726a..2725d4d45 100644
--- a/theme_enark/views/snippets/s_parallax.xml
+++ b/theme_enark/views/snippets/s_parallax.xml
@@ -10,7 +10,7 @@
     <xpath expr="//div[hasclass('oe_empty')]" position="after">
         <div class="container">
             <div class="row d-flex justify-content-start">
-                <h1><i>“One of the great beauties of architecture is that each time, it is like life starting all over again.”</i></h1>
+                <h2><i>“One of the great beauties of architecture is that each time, it is like life starting all over again.”</i></h2>
             </div>
         </div>
     </xpath>
diff --git a/theme_kiddo/views/snippets/s_cover.xml b/theme_kiddo/views/snippets/s_cover.xml
index ab71f0737..18d06fef4 100644
--- a/theme_kiddo/views/snippets/s_cover.xml
+++ b/theme_kiddo/views/snippets/s_cover.xml
@@ -13,7 +13,7 @@
     </xpath>
 
     <!-- Heading -->
-    <xpath expr="//font" position="replace" mode="inner">
+    <xpath expr="//h1" position="replace" mode="inner">
         Kiddo Nursery
     </xpath>
 
diff --git a/theme_kiddo/views/snippets/s_picture.xml b/theme_kiddo/views/snippets/s_picture.xml
index 0f4c054f8..50d42279c 100644
--- a/theme_kiddo/views/snippets/s_picture.xml
+++ b/theme_kiddo/views/snippets/s_picture.xml
@@ -8,7 +8,7 @@
     </xpath>
 
     <!-- Heading -->
-    <xpath expr="//font" position="replace" mode="inner">
+    <xpath expr="//h2" position="replace" mode="inner">
         Letting each child explore and grow at their own pace
     </xpath>
 
diff --git a/theme_loftspace/views/snippets/s_title.xml b/theme_loftspace/views/snippets/s_title.xml
index b74c7ffc2..3e38055b8 100644
--- a/theme_loftspace/views/snippets/s_title.xml
+++ b/theme_loftspace/views/snippets/s_title.xml
@@ -13,7 +13,7 @@
         <div class="o_we_bg_filter bg-black-50"/>
     </xpath>
     <!-- Title -->
-    <xpath expr="//h1" position="replace" mode="inner">
+    <xpath expr="//h2" position="replace" mode="inner">
         <b>Everything is designed.<br/> Few things are designed well.</b>
     </xpath>
 </template>
diff --git a/theme_monglia/views/customizations.xml b/theme_monglia/views/customizations.xml
index f81519a25..9e8a3605b 100644
--- a/theme_monglia/views/customizations.xml
+++ b/theme_monglia/views/customizations.xml
@@ -6,8 +6,8 @@
     <xpath expr="//section" position="attributes">
         <attribute name="class" add="o_cc o_cc5" separator=" "/>
     </xpath>
-    <xpath expr="//h1" position="replace">
-        <h1> <font style="background-image: linear-gradient(135deg, var(--o-color-4) 25%, var(--o-color-1) 100%);" class="text-gradient">MAIN LINE UP</font></h1>
+    <xpath expr="//h2" position="replace">
+        <h2><font style="background-image: linear-gradient(135deg, var(--o-color-4) 25%, var(--o-color-1) 100%);" class="text-gradient">MAIN LINE UP</font></h2>
     </xpath>
 </template>
 
diff --git a/theme_nano/views/snippets/s_cover.xml b/theme_nano/views/snippets/s_cover.xml
index 74601df84..3c9cad6dc 100644
--- a/theme_nano/views/snippets/s_cover.xml
+++ b/theme_nano/views/snippets/s_cover.xml
@@ -10,7 +10,7 @@
     </xpath>
     <xpath expr="//*[hasclass('s_parallax_bg')]" position="replace"/>
     <!-- Title & Text -->
-    <xpath expr="//h1//font" position="replace" mode="inner">
+    <xpath expr="//h1" position="replace" mode="inner">
         Creative Studio
     </xpath>
     <xpath expr="//p" position="replace" mode="inner">
diff --git a/theme_notes/views/snippets/s_carousel.xml b/theme_notes/views/snippets/s_carousel.xml
index 2769fe1c0..c61bf39af 100644
--- a/theme_notes/views/snippets/s_carousel.xml
+++ b/theme_notes/views/snippets/s_carousel.xml
@@ -8,7 +8,7 @@
     </xpath>
     <xpath expr="//div[hasclass('carousel-content')]" position="replace">
         <div class="carousel-content col-lg-6">
-            <h1>Miraillet Festival</h1>
+            <h2>Miraillet Festival</h2>
             <p class="lead">From the 12th to the 17th of August, come and enjoy the atmosphere at the Miraillet Festival. Discover the line up below.</p>
             <p><br/></p>
             <p><a href="/contactus" class="btn btn-primary btn-lg">More Info</a></p>
@@ -20,7 +20,7 @@
     </xpath>
     <xpath expr="(//div[hasclass('carousel-content')])[2]" position="replace">
         <div class="carousel-content col-lg-6">
-            <h1>6 Days Pass</h1>
+            <h2>6 Days Pass</h2>
             <p class="lead">Tickets will be on sale soon. Do not miss our 6 Days Pass. Free camping!</p>
             <p><br/></p>
             <p><a href="/" class="btn btn-primary btn-lg">More Info</a></p>
@@ -32,7 +32,7 @@
     </xpath>
     <xpath expr="(//div[hasclass('carousel-content')])[3]" position="replace">
         <div class="carousel-content col-lg-6">
-            <h1>Recent Editions</h1>
+            <h2>Recent Editions</h2>
             <p class="lead">Discover what makes the reputation of the Miraillet festival through these after-movies.</p>
             <p><br/></p>
             <p><a href="/" class="btn btn-primary btn-lg">More Info</a></p>
diff --git a/theme_odoo_experts/views/snippets/s_title.xml b/theme_odoo_experts/views/snippets/s_title.xml
index 3a3bae0ba..7c64cffab 100644
--- a/theme_odoo_experts/views/snippets/s_title.xml
+++ b/theme_odoo_experts/views/snippets/s_title.xml
@@ -3,7 +3,7 @@
 
 <template id="s_title" inherit_id="website.s_title">
     <!-- Section -->
-    <xpath expr="//h1/font" position="replace" mode="inner">
+    <xpath expr="//h2" position="replace" mode="inner">
         Pricing to suit<br/> all sizes of business
     </xpath>
 </template>
diff --git a/theme_paptic/views/customizations.xml b/theme_paptic/views/customizations.xml
index 0a79d1d17..c8368e86f 100644
--- a/theme_paptic/views/customizations.xml
+++ b/theme_paptic/views/customizations.xml
@@ -163,7 +163,7 @@
     <xpath expr="//section" position="attributes">
         <attribute name="class" add="pt96 pb80" remove="pt40 pb40" separator=" "/>
     </xpath>
-     <xpath expr="//h1" position="replace" mode="inner">
+     <xpath expr="//h2" position="replace" mode="inner">
         Unique experiences.
     </xpath>
 </template>
diff --git a/theme_treehouse/views/snippets/s_title.xml b/theme_treehouse/views/snippets/s_title.xml
index 95fa5e0bb..e6ec99e31 100644
--- a/theme_treehouse/views/snippets/s_title.xml
+++ b/theme_treehouse/views/snippets/s_title.xml
@@ -12,7 +12,7 @@
         <div class="o_we_bg_filter bg-black-50"/>
     </xpath>
     <!-- Title -->
-    <xpath expr="//h1" position="replace" mode="inner">
+    <xpath expr="//h2" position="replace" mode="inner">
         Changing the world is possible.<br/> We’ve done it before.
     </xpath>
 </template>
diff --git a/theme_yes/views/snippets/s_cover.xml b/theme_yes/views/snippets/s_cover.xml
index ece5576d3..177fb277f 100644
--- a/theme_yes/views/snippets/s_cover.xml
+++ b/theme_yes/views/snippets/s_cover.xml
@@ -11,8 +11,11 @@
         <div class="o_we_bg_filter" style="background-color: rgba(25, 41, 37, 0.55) !important;"/>
     </xpath>
     <!-- Title -->
+    <xpath expr="//h1" position="attributes">
+        <attribute name="class" add="display-1-fs" remove="display-3-fs" separator=" "/>
+    </xpath>
     <xpath expr="//h1" position="replace" mode="inner">
-        <font style="font-size: 92px; font-weight: bold;">Once in a lifetime moments</font>
+        Once in a lifetime moments
     </xpath>
     <!-- Paragraph -->
     <xpath expr="//p" position="replace" mode="inner">
diff --git a/theme_yes/views/snippets/s_picture.xml b/theme_yes/views/snippets/s_picture.xml
index edc4d1bc3..1485d8a21 100644
--- a/theme_yes/views/snippets/s_picture.xml
+++ b/theme_yes/views/snippets/s_picture.xml
@@ -7,7 +7,7 @@
         <attribute name="class" add="o_cc5" remove="o_cc2" separator=" "/>
     </xpath>
     <!-- Title -->
-    <xpath expr="//h2//font" position="replace" mode="inner">
+    <xpath expr="//h2" position="replace" mode="inner">
         Love is in the air
     </xpath>
     <!-- Paragraphs -->
diff --git a/theme_yes/views/snippets/s_title.xml b/theme_yes/views/snippets/s_title.xml
index d76e43264..23a0552ab 100644
--- a/theme_yes/views/snippets/s_title.xml
+++ b/theme_yes/views/snippets/s_title.xml
@@ -7,7 +7,7 @@
         <attribute name="class" add="o_cc o_cc2" separator=" "/>
     </xpath>
     <!-- Title -->
-    <xpath expr="//h1//font" position="replace" mode="inner">
+    <xpath expr="//h2" position="replace" mode="inner">
         Meet our team
     </xpath>
 </template>