NextERP/design-themes
2
0
Fork 0
mirror of https://github.com/odoo/design-themes.git synced 2025-10-07 01:18:52 +07:00
Code Issues Packages Projects Releases Wiki Activity

[IMP] test_themes: ensure styles only define properties once

Browse Source 
This commit adds a test that makes sure that inline styles do not
contain the same property several times.

task-4206845

closes odoo/design-themes#933

Related: odoo/odoo#181194
Signed-off-by: Alice Gaudon (agau) <agau@odoo.com>
This commit is contained in:
Benoit Socias
2024-09-24 14:16:40 +02:00
parent 266b35a31e
commit 199bd53c11
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test_themes/tests/test_new_page_templates.py
+6
View File
@@ -190,6 +190,12 @@ class TestNewPageTemplates(TransactionCase):
conflict.difference_update(white_list)
if len(conflict) > 1:
errors.append("Using %r, view %r contains conflicting classes: %r in %r (according to pattern %r)" % (theme_name, view.key, conflict, classes, conflicting_classes_re.pattern))
for el in html_tree.xpath('//*[@style]'):
styles = el.attrib['style'].split(';')
non_empty_styles = filter(lambda style: style, styles)
property_names = list(map(lambda style: style.split(':')[0].strip(), non_empty_styles))
if len(property_names) != len(set(property_names)):
errors.append("Using %r, view %r contains duplicate style properties: %r" % (theme_name, view.key, el.attrib['style']))
except Exception:
_logger.error("Using %r, view %r cannot be rendered", theme_name, view.key)
errors.append("Using %r, view %r cannot be rendered" % (theme_name, view.key))